Skip to content

error messages get swallowed #28

@matthias-mess

Description

@matthias-mess

r = self._doRequest(url, method, body, headers)
retry_http_codes = [503, 504]
if r.status_code in retry_http_codes and retry:
tries = 5
delay = .5
backoff = 2
while r.status_code in retry_http_codes and tries > 0:
tries -= 1
time.sleep(delay)
delay *= backoff
r = self._doRequest(url, method, body, headers)
r.raise_for_status()

The actual error message is in response.text and can't be accessed after the raise_for_status anymore. It's hard to know on application level what went wrong if the error is just "400 bad request". It would be good if the actual error message would be part of the exception message.

After hacking the library I found out that I actually got the error message {"msg":"Message must be no more than 64k"} from ironmq. I was spending have the day searching why my request is not working.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions