From aaa0bc1b3717e7275cdfda82b47fbd0ce65b977e Mon Sep 17 00:00:00 2001 From: Alex Lewin Date: Mon, 23 Feb 2026 09:27:31 +0000 Subject: [PATCH 1/3] Default assignment start date to today Only makes a difference in the frontend, to make it clearer to users that the assignment is starting today. In most circumstances we ignore a start date of today in the backend. --- src/app/components/elements/modals/SetAssignmentsModal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/elements/modals/SetAssignmentsModal.tsx b/src/app/components/elements/modals/SetAssignmentsModal.tsx index 55b3a501e1..fac823a66c 100644 --- a/src/app/components/elements/modals/SetAssignmentsModal.tsx +++ b/src/app/components/elements/modals/SetAssignmentsModal.tsx @@ -49,7 +49,7 @@ const AssignGroup = ({groups, currentAssignees, board, closeModal}: AssignGroupP const [selectedGroups, setSelectedGroups] = useState[]>([]); const [dueDate, setDueDate] = useState(UTC_MIDNIGHT_IN_SIX_DAYS); const [userSelectedDueDate, setUserSelectedDueDate] = useState(false); - const [scheduledStartDate, setScheduledStartDate] = useState(); + const [scheduledStartDate, setScheduledStartDate] = useState(TODAY); const [assignmentNotes, setAssignmentNotes] = useState(); const [validationAttempted, setValidationAttempted] = useState(false); const user = useAppSelector(selectors.user.loggedInOrNull); From 31d1ee4bc63a1de897ea00d025dbb6dda758363f Mon Sep 17 00:00:00 2001 From: Alex Lewin Date: Mon, 23 Feb 2026 09:27:51 +0000 Subject: [PATCH 2/3] Fix ESLint warning --- src/app/components/elements/modals/SetAssignmentsModal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/elements/modals/SetAssignmentsModal.tsx b/src/app/components/elements/modals/SetAssignmentsModal.tsx index fac823a66c..3d4c83298a 100644 --- a/src/app/components/elements/modals/SetAssignmentsModal.tsx +++ b/src/app/components/elements/modals/SetAssignmentsModal.tsx @@ -66,7 +66,7 @@ const AssignGroup = ({groups, currentAssignees, board, closeModal}: AssignGroupP } function assign() { - dispatch(assignGameboard({ + void dispatch(assignGameboard({ boardId: board?.id as string, groups: selectedGroups, dueDate, From 604e566f02f35f14c06e41a6bbf7167be509d2d9 Mon Sep 17 00:00:00 2001 From: Alex Lewin Date: Mon, 23 Feb 2026 09:38:05 +0000 Subject: [PATCH 3/3] Update tests --- src/test/pages/SetAssignments.test.tsx | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/test/pages/SetAssignments.test.tsx b/src/test/pages/SetAssignments.test.tsx index 038b3e580f..8d25de833a 100644 --- a/src/test/pages/SetAssignments.test.tsx +++ b/src/test/pages/SetAssignments.test.tsx @@ -213,7 +213,7 @@ describe("SetAssignments", () => { expect(requestAssignment(observer.observedParams!).gameboardId).toEqual(mockGameboard.id); expect(requestAssignment(observer.observedParams!).notes).toEqual(testNotes); expect(requestAssignment(observer.observedParams!).dueDate).toBeDefined(); - expect(requestAssignment(observer.observedParams!).scheduledStartDate).not.toBeDefined(); + expect(requestAssignment(observer.observedParams!).scheduledStartDate).toBeDefined(); }); // Close modal @@ -243,9 +243,11 @@ describe("SetAssignments", () => { expect(within(await modal()).getByTestId("modal-groups-selector")).toHaveTextContent('Groups:None'); }); - it('start date is empty by default', async () => { - await renderModal(); - expect(await dateInput("modal-start-date-selector")).toHaveValue(''); + it('start date is today by default', async () => { + await withMockedDate(Date.parse("2025-01-30"), async () => { + await renderModal(); + expect(await dateInput("modal-start-date-selector")).toHaveValue("2025-01-30"); + }); }); it('due date is a week from now by default', async() => {