Some examples in date_time_parser are failing

[binduwavell]

The explicit tests are working. However, tests over the examples are failing in a few places... For example:

use chrono::NaiveDate;
use date_time_parser::{DateParser, Recognizable};

let date = DateParser::parse("July 4 2020");

assert_eq!(date, Some(NaiveDate::from_ymd(2020, 7, 4)))

Here is a sample test failure related to that example:

---- src/lib.rs - (line 23) stdout ----
Test executable failed (exit code 101).

stderr:
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `Some(2021-06-05)`,
 right: `Some(2020-06-05)`', src/lib.rs:8:1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[isaacrlee]

@binduwavell Thanks for putting this together. I think this should be fixed by #3, just haven't quite gotten to looking that over yet.

[binduwavell]

Hmm, I'm not sure #3 does address this. It looks like that PR is for event_parser only and does not affect date_time_parser? Rust is creating tests from example code in comments. However, I don't see any such comments being updated in that PR or the code covered by those "tests".

I did some more digging and it does appear there are bugs around year handling... "July 4 2020" is in fact parsed as July 4 2021 which I think is wrong?

[isaacrlee]

I see what you're saying now. I took a closer look at the parsing methods in date_parse.rs and noticed that year parsing is in a very rudimentary state. Currently, years are only parsed when the "mm/dd/YYYY" format is passed in. Otherwise, the current year is used.

Not ideal for sure, but also not sure how easy it would be to implement year parsing for other formats given the current structure.