Use CombinedOutput for capturing SSH output (#108)

* Use CombinedOutput for capturing SSH output

Fixes a buffer writing bug where the function would return an empty string after a succesful read

* Restyled by gofmt (#109)

Co-authored-by: Restyled.io <commits@restyled.io>

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>

Author: 3 people

iterative/utils/ssh.go

@@ -1,7 +1,6 @@
 package utils
 
 import (
-	"bytes"
 	"crypto/rand"
 	"crypto/rsa"
 	"crypto/x509"
@@ -72,10 +71,10 @@ func RunCommand(command string, timeout time.Duration, hostAddress string, userN
 	}
 	defer session.Close()
 
-	var buffer bytes.Buffer
-	session.Stdout = &buffer
-	session.Stderr = &buffer
+	output, err := session.CombinedOutput(command)
+	if err != nil {
+		return "", err
+	}
 
-	err = session.Run(command)
-	return buffer.String(), err
+	return string(output), nil
 }