Fix k8s test fixture (#274)

#271 broke the tests because GitHub won't allow users to pass a secret between jobs. 🤦🏼‍♂️

Author: 0x2b3bfa0

.github/workflows/smoke.yml

@@ -10,61 +10,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - run: echo ✓
-  start:
-    needs: authorize
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
-    outputs:
-      kubeconfig: ${{ steps.cluster.outputs.kubeconfig }}
-    steps:
-    - id: cluster
-      run: |
-        az login \
-          --service-principal \
-          --user="$AZURE_CLIENT_ID" \
-          --password="$AZURE_CLIENT_SECRET" \
-          --tenant="$AZURE_TENANT_ID"
-        az account set \
-          --subscription="$AZURE_SUBSCRIPTION_ID"
-        az extension add \
-          --name=aks-preview
-        az provider register \
-          --namespace=Microsoft.ContainerService
-        az feature register \
-          --namespace=Microsoft.ContainerService \
-          --name=GPUDedicatedVHDPreview
-        az group create \
-          --name="tpiSmokeTestCluster$GITHUB_RUN_ID" \
-          --location=eastus
-        az aks create \
-          --resource-group="tpiSmokeTestCluster$GITHUB_RUN_ID" \
-          --name="tpiSmokeTestCluster$GITHUB_RUN_ID" \
-          --node-vm-size=Standard_NC6 \
-          --node-count=1 \
-          --aks-custom-headers=UseGPUDedicatedVHD=true \
-          --generate-ssh-keys
-        az aks get-credentials \
-          --resource-group="tpiSmokeTestCluster$GITHUB_RUN_ID" \
-          --name="tpiSmokeTestCluster$GITHUB_RUN_ID" \
-          --file - |
-        perl -0777p \
-          -e 's/%/%25/g;' \
-          -e 's/\n/%0A/g;' \
-          -e 's/\r/%0D/g;' \
-          -e 's/(.+)/::add-mask::\1\n::set-output name=kubeconfig::\1\n/g'
-      env:
-        AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
-        AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
-        AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
-        AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
   test:
-    needs: start
+    needs: authorize
     runs-on: ubuntu-latest
     timeout-minutes: 60
     strategy:
       fail-fast: false
       matrix:
-        provider: [AWS, AZ, GCP, K8S]
+        provider: [AWS, AZ, GCP]
     env:
       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
@@ -74,8 +27,6 @@ jobs:
       AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
       AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
       GOOGLE_APPLICATION_CREDENTIALS_DATA: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_DATA }}
-      KUBECONFIG_DATA: ${{ needs.start.outputs.kubeconfig }}
-      SMOKE_TEST_IDENTIFIER: smoke test ${{ github.run_id }}
       SMOKE_TEST_ENABLE_${{ matrix.provider }}: true
     steps:
     - uses: actions/checkout@v2
@@ -91,12 +42,20 @@ jobs:
       run: go test ./task -v -timeout=30m -count=1
       env:
         SMOKE_TEST_SWEEP: true
-  stop:
-    if: always()
-    needs: test
+  test-k8s:
+    needs: authorize
     runs-on: ubuntu-latest
     timeout-minutes: 30
+    env:
+      AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
+      AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
+      AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
+      AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
     steps:
+    - uses: actions/checkout@v2
+    - uses: actions/setup-go@v2
+      with:
+        go-version: ^1.17
     - run: |
         az login \
           --service-principal \
@@ -105,11 +64,42 @@ jobs:
           --tenant="$AZURE_TENANT_ID"
         az account set \
           --subscription="$AZURE_SUBSCRIPTION_ID"
+    - id: cluster
+      run: |
+        az extension add \
+          --name=aks-preview
+        az provider register \
+          --namespace=Microsoft.ContainerService
+        az feature register \
+          --namespace=Microsoft.ContainerService \
+          --name=GPUDedicatedVHDPreview
+        az group create \
+          --name="tpiSmokeTestCluster$GITHUB_RUN_ID" \
+          --location=eastus
+        az aks create \
+          --resource-group="tpiSmokeTestCluster$GITHUB_RUN_ID" \
+          --name="tpiSmokeTestCluster$GITHUB_RUN_ID" \
+          --node-vm-size=Standard_NC6 \
+          --node-count=1 \
+          --aks-custom-headers=UseGPUDedicatedVHD=true \
+          --generate-ssh-keys
+        az aks get-credentials \
+          --resource-group="tpiSmokeTestCluster$GITHUB_RUN_ID" \
+          --name="tpiSmokeTestCluster$GITHUB_RUN_ID" \
+          --file - |
+        perl -0777p \
+          -e 's/%/%25/g;' \
+          -e 's/\n/%0A/g;' \
+          -e 's/\r/%0D/g;' \
+          -e 's/(.+)/::add-mask::\1\n::set-output name=kubeconfig::\1\n/g'
+    - run: go test ./task -v -timeout=30m -count=1
+      env:
+        KUBECONFIG_DATA: ${{ steps.cluster.outputs.kubeconfig }}
+        SMOKE_TEST_ENABLE_K8S: true
+    - if: always()
+      run: |
         az group delete \
           --name="tpiSmokeTestCluster$GITHUB_RUN_ID" \
           --yes
-      env:
-        AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
-        AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
-        AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
-        AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
+env:
+  SMOKE_TEST_IDENTIFIER: smoke test ${{ github.run_id }}