Use global timeout on aws, az & gcp (#587)

* Use global timeout on `aws`, `az` & `gcp`

* Fix time/duration blunder

* Provide a consistent timeout message

* Simplify timeout

* Report timeout results as failures

Author: 0x2b3bfa0

task/common/machine/script.go

@@ -13,7 +13,7 @@ import (
 )
 
 func Script(script string, credentials *map[string]string, variables common.Variables, timeout time.Duration) string {
-	timeoutString := strconv.Itoa(int(timeout / time.Second))
+	timeoutString := strconv.Itoa(int(time.Now().Add(timeout).Unix()))
 	if timeout <= 0 {
 		timeoutString = "infinity"
 	}
@@ -67,21 +67,27 @@ TPI_MACHINE_IDENTITY="$(uuidgen)"
 TPI_LOG_DIRECTORY="$(mktemp --directory)"
 TPI_DATA_DIRECTORY="/opt/task/directory"
 
+TPI_START_COMMAND="/bin/bash -lc 'exec /usr/bin/tpi-task'"
+TPI_REMAINING_RUN_TIME=$((%s-$(date +%%s)))
+if (( TPI_REMAINING_RUN_TIME < 1 )); then
+  TPI_START_COMMAND="/bin/bash -c 'sleep infinity'"
+  TPI_REMAINING_RUN_TIME=1
+fi
+
 source /opt/task/credentials
 
 sudo tee /etc/systemd/system/tpi-task.service > /dev/null <<END
 [Unit]
   After=default.target
 [Service]
   Type=simple
-  ExecStart=-/bin/bash -lc 'exec /usr/bin/tpi-task'
+  ExecStart=-$TPI_START_COMMAND
   ExecStop=/bin/bash -c 'source /opt/task/credentials; systemctl is-system-running | grep stopping || echo "{\\\\"result\\\\": \\\\"\$SERVICE_RESULT\\\\", \\\\"code\\\\": \\\\"\$EXIT_STATUS\\\\", \\\\"status\\\\": \\\\"\$EXIT_CODE\\\\"}" > "$TPI_LOG_DIRECTORY/status-$TPI_MACHINE_IDENTITY" && RCLONE_CONFIG= rclone copy "$TPI_LOG_DIRECTORY" "\$RCLONE_REMOTE/reports"'
   ExecStopPost=/usr/bin/tpi-task-shutdown
   Environment=HOME=/root
   EnvironmentFile=/opt/task/variables
   WorkingDirectory=/opt/task/directory
-  TimeoutStartSec=%s
-  TimeoutStopSec=infinity
+  RuntimeMaxSec=$TPI_REMAINING_RUN_TIME
 [Install]
   WantedBy=default.target
 END

task/common/machine/storage.go

@@ -101,6 +101,8 @@ func Status(ctx context.Context, remote string, initialStatus common.Status) (co
 			} else {
 				initialStatus[common.StatusCodeFailed] += 1
 			}
+		} else if statusReport.Result == "timeout" {
+			initialStatus[common.StatusCodeFailed] += 1
 		}
 	}
 	return initialStatus, nil