Version 2.1.0 Doesn't Work

[paulgab]

I did have the OVMS/ABRP integration working, but it stopped. I saw there was a newer version, so I update the file /store/scripts/lib/abrp.js. I am running OVMS firmware version 3.3.003.

When I run Evaluate JS, I get the following message:
ERROR: ReferenceError: identifier 'module' undefined
at [anon] (duk_js_var.c:1236) internal
at eval (eval:882) preventsyield (line 882)

The following error appears in the editor console if reload the JS Engine:
E (632984054) ovms-duktape: [lib/abrp.js:175] TypeError: undefined not callable (property 'HasValue' of [object Object])
……: at [anon] (duk_js_call.c:2919) internal
……: at isOvmsMetricSupported (lib/abrp.js:175)
……: at getOVMSMetric (lib/abrp.js:225)
……: at createTelemetry (lib/abrp.js:548)
……: at sendTelemetryIfNecessary (lib/abrp.js:619)
……: at callSubscriberWithImmediateExceptions (int/PubSub.js:1) strict
……: at deliverMessage (int/PubSub.js:1) strict
……: at c (int/PubSub.js:1) strict
……: at publish (int/PubSub.js:1) strict
……: at [anon] (int/PubSub.js:1) strict preventsyield

[paulgab]

Hi,
I have played with a few previous versions of this file, and have restored OVMS/ABRP sync with version 2.0.1 of the file from Jun 20, 2023. Turns out the Evaluate JS message is a red herring, and occurs with a working version of the file.

The below bug was introduced in the commit "Refactored telemetry generation to account for vehicle to vehicle variations." Jun 21, 2023.

E (1135336054) ovms-duktape: [lib/abrp.js:175] TypeError: undefined not callable (property 'HasValue' of [object Object])
……: at [anon] (duk_js_call.c:2919) internal
……: at isOvmsMetricSupported (lib/abrp.js:175)
……: at getOVMSMetric (lib/abrp.js:225)
……: at createTelemetry (lib/abrp.js:548)
……: at sendTelemetryIfNecessary (lib/abrp.js:619)
……: at callSubscriberWithImmediateExceptions (int/PubSub.js:1) strict
……: at deliverMessage (int/PubSub.js:1) strict
……: at c (int/PubSub.js:1) strict
……: at publish (int/PubSub.js:1) strict
……: at [anon] (int/PubSub.js:1) strict preventsyield

[kezarjg]

What version of OVMS firmware are you using?

[paulgab]

The version of OVMS I'm am running now is 3.3.004/ota_1/main (build idf v3.3.4-849-g6e214dc33 Mar 24 2024 00:06:06), but at the time I was running OVMS firmware version 3.3.003.

I am still running version 2.0.1 of the file from Jun 20, 2023 of ovms-link, as it works.

[kezarjg]

Sorry, I missed that in your initial post.

The updated script requires the function OvmsMetrics.HasValue which was added in the 3.3.004 release (2024-03-23)