From 2f03f9bea57cd9ea807903a40f2816290dec7378 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Tue, 4 Oct 2022 00:20:03 +0000 Subject: [PATCH] vuln-fix: Temporary Directory Hijacking or Information Disclosure This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/10 Co-authored-by: Moderne --- .../java/com/itextpdf/testutils/CompareToolUtil.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/itext/src/main/java/com/itextpdf/testutils/CompareToolUtil.java b/itext/src/main/java/com/itextpdf/testutils/CompareToolUtil.java index 89a1c84da..514ee59c0 100644 --- a/itext/src/main/java/com/itextpdf/testutils/CompareToolUtil.java +++ b/itext/src/main/java/com/itextpdf/testutils/CompareToolUtil.java @@ -6,6 +6,7 @@ import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; +import java.nio.file.Files; import java.util.ArrayList; import java.util.Collections; import java.util.List; @@ -74,15 +75,7 @@ public static String createTempDirectory(String tempFilePrefix) throws IOException { final File temp; - temp = File.createTempFile("temp", Long.toString(System.nanoTime())); - - if(!(temp.delete())) { - throw new IOException("Could not delete temp file: " + temp.getAbsolutePath()); - } - - if(!(temp.mkdir())) { - throw new IOException("Could not create temp directory: " + temp.getAbsolutePath()); - } + temp = Files.createTempDirectory("temp" + Long.toString(System.nanoTime())).toFile(); return temp.toString(); }