Merge pull request #119 from itk-dev-rpa/hotfix/missing-approve-all-button

changed approve buttons to use find elements, allowing a check if we …

Author: bakspace-itk

changelog.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.14.1] - 2025-09-05
+
+### Fixed
+
+- In case the "Godkend Alle" button does not exist, the robot will now correctly progress.
+
 ## [2.14.0] - 2025-08-22
 
 ### Changed

itk_dev_shared_components/eflyt/eflyt_case.py

@@ -144,9 +144,9 @@ def approve_case(browser: webdriver.Chrome):
     browser.find_element(By.ID, "ctl00_ContentPlaceHolder2_ptFanePerson_stcPersonTab1_btnGodkend").click()
     browser.find_element(By.ID, "ctl00_ContentPlaceHolder2_ptFanePerson_stcPersonTab1_btnApproveYes").click()
 
-    approve_persons_button = browser.find_element(By.ID, "ctl00_ContentPlaceHolder2_ptFanePerson_stcPersonTab1_btnGodkendAlle")
-    if approve_persons_button.is_enabled():
-        approve_persons_button.click()
+    approve_persons_button = browser.find_elements(By.ID, "ctl00_ContentPlaceHolder2_ptFanePerson_stcPersonTab1_btnGodkendAlle")
+    if any(approve_persons_button) and approve_persons_button[0].is_enabled():
+        approve_persons_button[0].click()
     else:
         # Approve each person individually
         person_count = len(browser.find_elements(By.XPATH, '//table[@id="ctl00_ContentPlaceHolder2_GridViewMovingPersons"]//tr')) - 1

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "itk_dev_shared_components"
-version = "2.14.0"
+version = "2.14.1"
 authors = [
   { name="ITK Development", email="itk-rpa@mkb.aarhus.dk" },
 ]