Merge pull request #87 from itk-dev-rpa/feature/get_nova_case

Added get_case in nova

Author: ghbm-itk

changelog.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - misc.cpr_util: Function to get birth date from cpr number.
+- kmd_nova.nova_cases: Function to get a case on its uuid.
 
 ## [2.7.1] - 2024-09-24
 

itk_dev_shared_components/kmd_nova/nova_cases.py

@@ -12,6 +12,28 @@
 from itk_dev_shared_components.kmd_nova.util import datetime_from_iso_string
 
 
+def get_case(case_uuid: str, nova_access: NovaAccess) -> NovaCase:
+    """Get a case from based on its uuid.
+
+    Args:
+        case_uuid: The uuid of the case to get.
+        nova_access: The NovaAccess object used to authenticate.
+
+    Raises:
+        ValueError: If no case was found.
+
+    Returns:
+        The case with the given uuid.
+    """
+    payload = _create_payload(case_uuid=case_uuid)
+    cases = _get_nova_cases(nova_access, payload)
+
+    if not cases:
+        raise ValueError(f"No case found with the given uuid: {case_uuid}")
+
+    return cases[0]
+
+
 def get_cases(nova_access: NovaAccess, cpr: str = None, case_number: str = None, case_title: str = None, limit: int = 100) -> list[NovaCase]:
     """Search for cases on different search terms.
     Currently supports search on cpr number, case number and case title. At least one search term must be given.
@@ -33,7 +55,7 @@ def get_cases(nova_access: NovaAccess, cpr: str = None, case_number: str = None,
     if not any((cpr, case_number, case_title)):
         raise ValueError("No search terms given.")
 
-    payload = _create_payload(cpr, "CprNummer", case_number, case_title, limit)
+    payload = _create_payload(identification=cpr, identification_type="CprNummer", case_number=case_number, case_title=case_title, limit=limit)
     return _get_nova_cases(nova_access, payload)
 
 
@@ -58,7 +80,7 @@ def get_cvr_cases(nova_access: NovaAccess, cvr: str = None,  case_number: str =
     if not any((cvr, case_number, case_title)):
         raise ValueError("No search terms given.")
 
-    payload = _create_payload(cvr, "CvrNummer", case_number, case_title, limit)
+    payload = _create_payload(identification=cvr, identification_type="CvrNummer", case_number=case_number, case_title=case_title, limit=limit)
     return _get_nova_cases(nova_access, payload)
 
 
@@ -113,10 +135,11 @@ def _get_nova_cases(nova_access: NovaAccess, payload: dict) -> list[NovaCase]:
     return cases
 
 
-def _create_payload(identification: str = None, identification_type: str = "CprNummer", case_number: str = None, case_title: str = None, limit: int = 100) -> dict:
+def _create_payload(*, case_uuid: str = None, identification: str = None, identification_type: str = "CprNummer", case_number: str = None, case_title: str = None, limit: int = 100) -> dict:
     return {
         "common": {
-            "transactionId": str(uuid.uuid4())
+            "transactionId": str(uuid.uuid4()),
+            "uuid": case_uuid
         },
         "paging": {
             "startRow": 1,

tests/test_nova_api/test_cases.py

@@ -87,7 +87,9 @@ def test_get_cvr_cases(self):
             nova_cases.get_cvr_cases(nova_access=self.nova_access)
 
     def test_add_case(self):
-        """Test adding a case to Nova."""
+        """Test adding a case to Nova.
+        Also tests getting a case on uuid.
+        """
         nova_party = os.getenv('NOVA_PARTY').split(',')
         party = CaseParty(
             role="Primær",
@@ -126,17 +128,14 @@ def test_add_case(self):
         nova_case = None
         for _ in range(10):
             time.sleep(1)
-            cases = nova_cases.get_cases(self.nova_access, cpr=party.identification, case_title="Test")
-            for c in cases:
-                if c.title == case.title:
-                    nova_case = c
-                    break
-            if nova_case:
+            try:
+                nova_case = nova_cases.get_case(case.uuid, self.nova_access)
                 break
+            except ValueError:
+                pass
 
         self.assertIsNotNone(nova_case)
 
-        nova_case = cases[0]
         self.assertEqual(nova_case.uuid, case.uuid)
         self.assertEqual(nova_case.title, case.title)
         self.assertEqual(nova_case.progress_state, case.progress_state)