Merge pull request #77 from itk-dev-rpa/hotfix/case_worker_row_number

Hotfix/case worker row number

Author: bakspace-itk

changelog.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.6.1] - 2024-09-04
+
+### Fixed - 2024-09-04
+
+- Fixed column number on case_worker
+
 ## [2.6.0] - 2024-09-04
 
 ### Added
@@ -154,7 +160,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Initial release
 
-[Unreleased]: https://github.com/itk-dev-rpa/ITK-dev-shared-components/compare/2.6.0...HEAD
+[Unreleased]: https://github.com/itk-dev-rpa/ITK-dev-shared-components/compare/2.6.1...HEAD
+[2.6.0]: https://github.com/itk-dev-rpa/ITK-dev-shared-components/releases/tag/2.6.1
 [2.6.0]: https://github.com/itk-dev-rpa/ITK-dev-shared-components/releases/tag/2.6.0
 [2.5.0]: https://github.com/itk-dev-rpa/ITK-dev-shared-components/releases/tag/2.5.0
 [2.4.0]: https://github.com/itk-dev-rpa/ITK-dev-shared-components/releases/tag/2.4.0

itk_dev_shared_components/eflyt/eflyt_search.py

@@ -81,7 +81,7 @@ def extract_cases(browser: webdriver.Chrome) -> list[Case]:
         status = row.find_element(By.XPATH, "td[6]").text
         cpr = row.find_element(By.XPATH, "td[7]/a").text
         name = row.find_element(By.XPATH, "td[8]").text
-        case_worker = row.find_element(By.XPATH, "td[9]").text
+        case_worker = row.find_element(By.XPATH, "td[10]").text
 
         case = Case(case_number, deadline, case_types, status, cpr, name, case_worker)
         cases.append(case)

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "itk_dev_shared_components"
-version = "2.6.0"
+version = "2.6.1"
 authors = [
   { name="ITK Development", email="itk-rpa@mkb.aarhus.dk" },
 ]

tests/test_eflyt/test_search.py

@@ -35,8 +35,11 @@ def test_extract_cases(self):
         self.assertIsInstance(case.deadline, (date, type(None)))
         self.assertIsInstance(case.status, str)
         self.assertIsInstance(case.cpr, str)
+        self.assertRegex(case.cpr, r"\d{6}-\d{4}")
         self.assertIsInstance(case.name, str)
+        self.assertGreater(len(case.name), 0)
         self.assertIsInstance(case.case_worker, str)
+        self.assertGreater(len(case.case_worker), 0)
 
     def test_open_case(self):
         """Open a case and check the browser opened the case view"""