From a55e25057ddbfbb55816aa7dc9ccf32a15827e7a Mon Sep 17 00:00:00 2001 From: kri-bak Date: Fri, 5 Sep 2025 13:01:17 +0200 Subject: [PATCH 1/3] changed approve buttons to use find elements, allowing a check if we find anything. --- itk_dev_shared_components/eflyt/eflyt_case.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/itk_dev_shared_components/eflyt/eflyt_case.py b/itk_dev_shared_components/eflyt/eflyt_case.py index c4e5380..f9792a7 100644 --- a/itk_dev_shared_components/eflyt/eflyt_case.py +++ b/itk_dev_shared_components/eflyt/eflyt_case.py @@ -144,9 +144,9 @@ def approve_case(browser: webdriver.Chrome): browser.find_element(By.ID, "ctl00_ContentPlaceHolder2_ptFanePerson_stcPersonTab1_btnGodkend").click() browser.find_element(By.ID, "ctl00_ContentPlaceHolder2_ptFanePerson_stcPersonTab1_btnApproveYes").click() - approve_persons_button = browser.find_element(By.ID, "ctl00_ContentPlaceHolder2_ptFanePerson_stcPersonTab1_btnGodkendAlle") - if approve_persons_button.is_enabled(): - approve_persons_button.click() + approve_persons_button = browser.find_elements(By.ID, "ctl00_ContentPlaceHolder2_ptFanePerson_stcPersonTab1_btnGodkendAlle") + if any(approve_persons_button) and approve_persons_button[0].is_enabled(): + approve_persons_button[0].click() else: # Approve each person individually person_count = len(browser.find_elements(By.XPATH, '//table[@id="ctl00_ContentPlaceHolder2_GridViewMovingPersons"]//tr')) - 1 From dfa5f5cc284a5c51ba5d3395ac284c7454bd1a84 Mon Sep 17 00:00:00 2001 From: kri-bak Date: Fri, 5 Sep 2025 13:12:07 +0200 Subject: [PATCH 2/3] changelog --- changelog.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/changelog.md b/changelog.md index d79739d..def6a9a 100644 --- a/changelog.md +++ b/changelog.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- In case the "Godkend Alle" button does not exist, the robot will now correctly progress. + ## [2.14.0] - 2025-08-22 ### Changed From b8949969a4fd6f497ee85be07fe2f13686f27a7c Mon Sep 17 00:00:00 2001 From: kri-bak Date: Fri, 5 Sep 2025 13:14:00 +0200 Subject: [PATCH 3/3] hotfix changelog and version number --- changelog.md | 2 ++ pyproject.toml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/changelog.md b/changelog.md index def6a9a..9f220c9 100644 --- a/changelog.md +++ b/changelog.md @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [2.14.1] - 2025-09-05 + ### Fixed - In case the "Godkend Alle" button does not exist, the robot will now correctly progress. diff --git a/pyproject.toml b/pyproject.toml index eb528fa..6149ac7 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta" [project] name = "itk_dev_shared_components" -version = "2.14.0" +version = "2.14.1" authors = [ { name="ITK Development", email="itk-rpa@mkb.aarhus.dk" }, ]