hunted down a bug with Delete

[unlightednetting]

Hi, I just wanted to contribute to a small fix, despite not knowing much about github

I downloaded stream-chat-0.3.3 from here yesterday, and noticed that Deleted Messages don't remove themselves.

I had a peek into chat.html, and I did find out that code should support this, so I opened the file and found the bug.

It seems at some point, the Event Data changed the name structure, from targetMessageID to just plain messageID

In my file, this is at line 1275,
} else if (wsdata.event.type === 'ChatMessageDeleted') { console.debug(['Message deleted', wsdata]); remove_messages_by_message_id(wsdata.data.targetMessageId);

changing the final line to wsdata.data.messageID cleared up the problem

Thank you for the app and the work you do

[prkaigithub]

I've been dealing with the messages not deleting from the overlay for ages now and tried this and it didn't fix it for me either actually.

[unlightednetting]

Oh dear. Have you checked that when you Paste it into OBS, that the pasted link included the option to delete messages? In options.md it will show you which text you should delete As well, once you attempt any html edits, you do have to fully close OBS from the little side menu and then open again If there's a way to send private messages, please do share your chat.html and your browser source link

…

On Wed, Jan 8, 2025, at 10:19 AM, prkaigithub wrote: I've been dealing with the messages not deleting from the overlay for ages now and tried this and it didn't fix it for me either actually. — Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABERJNTDQQQTMKSPHRW6WBT2JU6ZFAVCNFSM6AAAAABUO5DJQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZXHEZTKNZSHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[unlightednetting]

Oops. In options.md it should show you which text to include. I'm not at the PC so I can't check , or edit my post

…

On Wed, Jan 8, 2025, at 10:19 AM, prkaigithub wrote: I've been dealing with the messages not deleting from the overlay for ages now and tried this and it didn't fix it for me either actually. — Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABERJNTDQQQTMKSPHRW6WBT2JU6ZFAVCNFSM6AAAAABUO5DJQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZXHEZTKNZSHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[prkaigithub]

I've included a screenshot of the options file from 0.3.3 and I don't see any options for deletion but it's been a long day/night for me so I could be missing something. lol I've also included my browser source link:

file:///C:/Users/Username/Desktop/StreamChat/chat.html?version_check=true&sb_enabled=true&sb_ws_uri=ws%3A%2F%2F127.0.0.1%3A8080&sb_twitch=true&sb_youtube=true&badges=true&badges_left=true&highlights=true&announcements=true&msg_color=ffffff&fontsize=1.35em&emote_size=42px&timestamp_locale=en-US&version_alert=false&direction=vertical&bubbles=false&timestamp=false

My chat.html is mostly unaltered except for adding a drop shadow to the text, changing some sizing and customizing a message. But for diagnostics I've been running a completely unaltered version just to eliminate any possibilities.

and have been fully closing OBS.

Thanks for your help btw. :)

[unlightednetting]

Yeah, sounds fine to me <3 So, in my original post, you might see, that the fix is to go into chat.html and edit one line of code. You want to take the words at the very end of that line of code, and use my replacement for it The end of the line looks for targetMessageID and you want to change that to messageID, removing the word target and minding the capital M turns lowercase There's a similar bug with deleting banned chatters, and that's detailed in another post that I made. Please do tell me how you get on with it <3

…

On Wed, Jan 8, 2025, at 5:39 PM, prkaigithub wrote: I've included a screenshot of the options file from 0.3.3 and I don't see any options for deletion but it's been a long day/night for me so I could be missing something. lol I've also included my browser source link: file:///C:/Users/Username/Desktop/StreamChat/chat.html?version_check=true&sb_enabled=true&sb_ws_uri=ws%3A%2F%2F127.0.0.1%3A8080&sb_twitch=true&sb_youtube=true&badges=true&badges_left=true&highlights=true&announcements=true&msg_color=ffffff&fontsize=1.35em&emote_size=42px&timestamp_locale=en-US&version_alert=false&direction=vertical&bubbles=false&timestamp=false options.png (view on web) <https://github.com/user-attachments/assets/d6129364-d23b-4d28-a353-6731d1ba770b> My chat.html is mostly unaltered except for adding a drop shadow to the text, changing some sizing and customizing a message. But for diagnostics I've been running a completely unaltered version just to eliminate any possibilities. and have been fully closing OBS. Thanks for your help btw. :) — Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABERJNVBDKJIGF3XQ5EGDDT2JWSKBAVCNFSM6AAAAABUO5DJQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZYHAYTGNRRGY>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[prkaigithub]

This is the change I have and it doesn't do anything on my end. Messages get removed from Twitch chat but not the overlay still. shrug

[unlightednetting]

ah, so! It might be that it's capitalization sensitive. I noticed that you type ID as both capitals, but only the I should be capitalized. So it should be messageId with a lowercase D for it as well, you can test and see for what error comes up, by opening the chat.html in your browser, making sure streamer bot is open, and pressing f12 at the bottom you'll have many many tabs, called Inspector, Console, and in Console, it shows the data you're looking for it should give 3 events Mine says Event, Event, and then Message Deleted, which is how I found this information for "messageId"

…

On Wed, Jan 8, 2025, at 8:00 PM, prkaigithub wrote: This is the change I have and it doesn't do anything on my end. Messages get removed from Twitch chat but not the overlay still. *shrug* chat.html.png (view on web) <https://github.com/user-attachments/assets/44b5d863-b369-40fc-847a-56e164286030> — Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABERJNQRRNHJRRJ7R35WKRL2JXCZTAVCNFSM6AAAAABUO5DJQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZYHE4DIMJXGQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[prkaigithub]

It was the capitalization. sigh lol Thank you ever so much! Seriously, that was gonna drive me mad. Can't thank you enough!

[unlightednetting]

Programming is like that, yeah ;w; Go into the other Issues where I posted one, and do the edits for bans/timeouts, too

…

On Wed, Jan 8, 2025, at 10:52 PM, prkaigithub wrote: It was the capitalization. *sigh* lol Thank you ever so much! Seriously, that was gonna drive me mad. Can't thank you enough! — Reply to this email directly, view it on GitHub <#57 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABERJNX5H7BZL5QE4MQDLST2JXW6DAVCNFSM6AAAAABUO5DJQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZZGEZDSMJZHA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[prkaigithub]

I don't see any other Issues with you (ran a filter for your name, this is all that comes up).

[unlightednetting]

Oops, you're so right. Someone else made it. here you go
#55