Merge pull request #28 from kozakura913/master

Jared Forth · web-flow · commit a981a30e347b · 2023-07-11T10:31:36.000-05:00
fix WebPPicture memory leak
diff --git a/src/encoder.rs b/src/encoder.rs
@@ -92,8 +92,10 @@ impl<'a> Encoder<'a> {
 
     pub fn encode_advanced(&self, config: &WebPConfig) -> Result<WebPMemory, WebPEncodingError> {
         unsafe {
-            let picture = new_picture(self.image, self.layout, self.width, self.height);
-            encode(picture, config)
+            let mut picture = new_picture(self.image, self.layout, self.width, self.height);
+            let res = encode(picture, config);
+            libwebp_sys::WebPPictureFree(&mut picture as *mut _);
+            res
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,10 @@ impl<'a> Encoder<'a> {`
`92`	`92`
`93`	`93`	`pub fn encode_advanced(&self, config: &WebPConfig) -> Result<WebPMemory, WebPEncodingError> {`
`94`	`94`	`unsafe {`
`95`		`- let picture = new_picture(self.image, self.layout, self.width, self.height);`
`96`		`- encode(picture, config)`
	`95`	`+ let mut picture = new_picture(self.image, self.layout, self.width, self.height);`
	`96`	`+ let res = encode(picture, config);`
	`97`	`+ libwebp_sys::WebPPictureFree(&mut picture as *mut _);`
	`98`	`+ res`
`97`	`99`	`}`
`98`	`100`	`}`
`99`	`101`	`}`