From 07cd8e5afdb891be18ddb474401c295dd8700744 Mon Sep 17 00:00:00 2001 From: Test Date: Sat, 25 Apr 2026 23:15:17 -0700 Subject: [PATCH 1/2] fix(geocoding): make Navigate tappable in peek + close search dropdown on Navigate here Two related taps were silently swallowed. 1. Geocode-bar Navigate button missing from peek pointer-events opt-in. The bar in peek state has pointer-events: none and only handle/copy/close/addr were explicitly opted back in. On mobile Safari the implicit child-receives-events behaviour for a pointer-events: none parent is unreliable, so .geocode-bar__nav silently dropped taps. Add it to the opt-in list. Without Navigate firing, hideGeocodeBar() from #176 never ran, so the bar stayed visible and the guidance pill's Stop button was still under the bar's drag handle. 2. Search dropdown's Navigate here handler started guidance without closing the dropdown. The dropdown sits at z-index 2000 above the guidance pill and on smaller viewports can overlap its action area; also a UX nit (stale chrome). Add hideDropdown() to the click handler. Closes #177 Co-Authored-By: Claude Opus 4.7 (1M context) --- src/geocoding.ts | 2 ++ src/style.css | 1 + 2 files changed, 3 insertions(+) diff --git a/src/geocoding.ts b/src/geocoding.ts index e75a89d..79f45ff 100644 --- a/src/geocoding.ts +++ b/src/geocoding.ts @@ -249,6 +249,8 @@ export function addSearchControl(map: L.Map, state: AppState, onNoResults: (mess const lng = parseFloat(li.dataset['lng'] ?? ''); if (isNaN(lat) || isNaN(lng)) return; const label = li.dataset['name'] ?? `${lat.toFixed(5)}, ${lng.toFixed(5)}`; + // Hide the search dropdown so it can't overlap the guidance pill (#177). + hideDropdown(); void startGuidance(state, map, { lat, lng, label }, onNoResults); return; } diff --git a/src/style.css b/src/style.css index ab86a87..6b4965c 100644 --- a/src/style.css +++ b/src/style.css @@ -657,6 +657,7 @@ body { height: 100%; width: 100%; padding: 0; margin: 0; } } .geocode-bar--peek .geocode-bar__handle, +.geocode-bar--peek .geocode-bar__nav, .geocode-bar--peek .geocode-bar__copy, .geocode-bar--peek .geocode-bar__close, .geocode-bar--peek .geocode-bar__addr { From 00104a16bcb5e9ecac8cdb7eed0674859e8ff884 Mon Sep 17 00:00:00 2001 From: Test Date: Sat, 25 Apr 2026 23:17:39 -0700 Subject: [PATCH 2/2] fix: drop issue ref from inline comment per CLAUDE.md Per PR #178 review nit. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/geocoding.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/geocoding.ts b/src/geocoding.ts index 79f45ff..603c4fb 100644 --- a/src/geocoding.ts +++ b/src/geocoding.ts @@ -249,7 +249,7 @@ export function addSearchControl(map: L.Map, state: AppState, onNoResults: (mess const lng = parseFloat(li.dataset['lng'] ?? ''); if (isNaN(lat) || isNaN(lng)) return; const label = li.dataset['name'] ?? `${lat.toFixed(5)}, ${lng.toFixed(5)}`; - // Hide the search dropdown so it can't overlap the guidance pill (#177). + // Dropdown is z-index 2000; close it before the guidance pill appears. hideDropdown(); void startGuidance(state, map, { lat, lng, label }, onNoResults); return;