Skip to content

Commit 89d008a

Browse files
committed
Fix breaking changes selenium 4.1.3 WebDriverWait duration
1 parent d96ed8a commit 89d008a

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

src/it/java/giis/demo/descuento/it/TestDescuentoSelema.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import org.junit.runner.RunWith;
44
import static org.junit.Assert.assertEquals;
55

6+
import java.time.Duration;
7+
68
import org.springframework.beans.factory.annotation.Autowired;
79
import org.springframework.boot.test.context.SpringBootTest;
810
import org.springframework.boot.web.server.LocalServerPort;
@@ -98,7 +100,7 @@ public void testDescuentoScenario() {
98100
}
99101
private void doStep(boolean initialStep, String edad, String expected) {
100102
WebElement txtEdad;
101-
txtEdad = (new WebDriverWait(sm.driver(), 5))
103+
txtEdad = (new WebDriverWait(sm.driver(), Duration.ofSeconds(5)))
102104
.until(ExpectedConditions.presenceOfElementLocated(By.id("txtEdad")));
103105

104106
if (initialStep) {

src/it/java/giis/demo/descuento/it/TestDescuentoSelenium.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import org.junit.runner.RunWith;
44
import static org.junit.Assert.assertEquals;
55

6+
import java.time.Duration;
7+
68
import org.springframework.beans.factory.annotation.Autowired;
79
import org.springframework.boot.test.context.SpringBootTest;
810
import org.springframework.boot.web.server.LocalServerPort;
@@ -143,7 +145,7 @@ private void doStep(boolean initialStep, String edad, String expected) {
143145
//causando una excepcion.
144146
//Esto es tipico cuando se usa/incluye javascript, y tambien depende del navegador y la velocidad del equipo.
145147
//Este elemento se obtendra utilizando una espera explicita
146-
txtEdad = (new WebDriverWait(driver, 5))
148+
txtEdad = (new WebDriverWait(driver, Duration.ofSeconds(5)))
147149
.until(ExpectedConditions.presenceOfElementLocated(By.id("txtEdad")));
148150
//Existen tambien formas de establecer un tiempo implicito para el driver.
149151
//Ver: https://www.seleniumhq.org/docs/04_webdriver_advanced.jsp#explicit-and-implicit-waits

src/it/java/giis/demo/descuento/it/jbehave/DescuentoITSteps.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package giis.demo.descuento.it.jbehave;
22
import static org.junit.Assert.assertEquals;
33

4+
import java.time.Duration;
45
import java.util.ArrayList;
56
import java.util.List;
67
import java.util.Map;
@@ -80,7 +81,7 @@ public void setEdad() {
8081
}
8182
private void doSetEdad(String edad) {
8283
WebElement txtEdad;
83-
txtEdad = (new WebDriverWait(driver, 5)).until(ExpectedConditions.presenceOfElementLocated(By.id("txtEdad")));
84+
txtEdad = (new WebDriverWait(driver, Duration.ofSeconds(5))).until(ExpectedConditions.presenceOfElementLocated(By.id("txtEdad")));
8485
txtEdad.clear(); //si no se limpia antes, sendKeys concatenara con el texto existente
8586
txtEdad.sendKeys(edad);
8687
driver.findElement(By.id("btnEdad")).click();

0 commit comments

Comments
 (0)