Skip to content

Commit 166e354

Browse files
committed
minor fixes
1 parent 556824e commit 166e354

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "coding-challenge-table",
2+
"name": "vue-coding-challenge",
33
"version": "0.1.0",
44
"private": true,
55
"scripts": {

public/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
<meta http-equiv="X-UA-Compatible" content="IE=edge">
66
<meta name="viewport" content="width=device-width,initial-scale=1.0">
77
<link rel="icon" href="<%= BASE_URL %>favicon.ico">
8-
<title>coding-challenge-table</title>
8+
<title>vue-coding-challenge</title>
99
</head>
1010
<body>
1111
<noscript>
12-
<strong>We're sorry but coding-challenge-table doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
12+
<strong>We're sorry but vue-coding-challenge doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
1313
</noscript>
1414
<div id="app"></div>
1515
<!-- built files will be auto injected -->

src/App.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</template>
99

1010
<script>
11-
import usersObj from '../data/User.json';
11+
import usersObj from '@/data/User.json';
1212
export default {
1313
name: 'App',
1414
data() {

src/components/TicketsTable/SortFilterSearch.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ export default {
2121
},
2222
performSearch: function() {
2323
let searchInput = this.userSearchInput;
24+
if (searchInput.trim() === "") {
25+
return;
26+
}
2427
let keysToSearch = [
2528
"Requestor",
2629
"ITOwner",
@@ -111,10 +114,7 @@ export default {
111114
this.performFilterSearch();
112115
},
113116
onSortChange: function(params) { // event from vue-good-table
114-
params.forEach(function(entry){
115-
console.log(entry.type);
116-
});
117-
params = params.pop();
117+
params = params[0];
118118
let field = params.field;
119119
let type = params.type;
120120
this.serverParams.sort = {

0 commit comments

Comments
 (0)