save_file may overwrite

[jeanphilippegoldman]

if several sound objects with same name are selected and used for save_file script, the last one will overwrite all the others...

[rolandomunoz]

We could add a _000 to all files by default. Then, _001, _002... Is that ok for you?

[jeanphilippegoldman]

i would say 'add nothing' by default (otherwise you will end up with all files with _000, not wanted)
and if a file has same name as previous then make a warning with options : 1stop saving files (so the user rename one or two objects in praat, then relaunch) , or 2 continue but with serialization (_001, _002).
anyhow all this should not happen often
what do you think ?

[rolandomunoz]

Sounds good, but what happens when the user have many of these cases? Users would have to decide for each file what to do. Maybe, in the warning, we could add a boolean Apply to all files, and the buttons Rewrite and Keep files.
Alternatively, we can add a boolean in the form/endform block which tells the script how to behave in duplication cases. This way, we do not ask the user for each case.

Which option do you think we should implement?

[jeanphilippegoldman]

lets keep it simple. i think this case wont happen much. usually users have distinct names.
i dont agree when you say ' Users would have to decide for each file what to do'. it would happen only when an object named similarly to a previous first occurs. say you have these names: A B A A B B C D A B, the warning would appears only twice when processing object at object #3 and #5.

so again i would go for a warning saying abort all (then user should rename himself or call a tool that would do exactly this: checking if redundant object name and offer various possibilities such as serialization), or continue&overwrite (i.e the user doesn't care).

my feeling is that we should keep the tools separated, what do you think ?

[rolandomunoz]

Thank you for your explanation, now it is more clear for me. I understand that we want to warn users about overwriting files. Does this also mean that we have to check the name of the previous files stored in the output folder?

I have think it a litte and this could be the seudocode

selectObject: object
if fileReadable(object_fullpath$)
  # Display a warning windows(beginPause/endPause) with two options: 1) continue&overwrite or 2) serialization  
else
  # Save object
endif

I think serialization is easy to implement as basic mechanism for this script. It would be nice if we could keep this feature. What do you think?

[jeanphilippegoldman]

ah, i understand now the ambiguity. i was talking about objects in praat with similar names so they would be named the same in folder and so only the last one would be really kept on disk. while you were talking of files already in saved in folders. i think both of these matter.

for the second one, Praat already asks for overwriting when saving one file. we should do the same as your pseudo code do.

for the first one : i think the serialization is not clear how we want it. so lets make a simple warning giving the choice abort or overwrite , and let the user rename his files manually or with a tool. I think we should dev this tool as a check that could appear in the menu and that could be also called as a check at the beginning of our save files script. what do you think ?
anyhow, we should not spend all our time, energy and motivation on this issue.

[rolandomunoz]

I have implemented the second option (check for duplication in folders).

Here is an idea for the first option (check for duplication within Praat objects). However, it is not clear for me why should the script warn the user if two objects of the same type share the same name when the mechanism for saving files can also do this task.

n=numberOfSelected()
objects# = selected# ()

str_object_names=Create Strings as tokens: "", " ,"

# Check if two or more objects share the same name

selectObject: objects#
for i to size(objects#)
  object_name$= selected$(i)
  selectObject: str_object_names
  Insert string: 0, object_name$
  selectObject: objects#   
endfor

selectObject: str_object_names
Sort

filename_temp$ = ""
for i to size(objects#)
  filename$ = object$[str_object_names, i]
  if filename$ == filename_temp$
    selectObject: filename$
    exitScript: "The object ""'filename$'"" is duplicated"
  endif
  filename_temp$ = filename$
endfor

writeInfoLine: Done