Cobalt: Update lifecycle terminology to Activating/Deactivating#5
Closed
Cobalt: Update lifecycle terminology to Activating/Deactivating#5
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames 'downward' transitions to 'deactivating' transitions to clarify the application lifecycle state machine. The review identified a logic error in the transition check where the initial startup (kInitial to kStarted) is incorrectly classified as deactivating due to the underlying enum values. This could cause the OS thread to block unnecessarily during startup. A code suggestion was provided to exclude the initial state from this check and update the documentation to resolve the semantic inconsistency.
jellefoks
force-pushed
the
lifecycle_terminology_cleanup_v2
branch
from
e6c89f9 to
efcfa20
Compare
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the 'downward' transitions to 'deactivating' transitions to clarify the application lifecycle state machine.
Bug: 492166511
Bug: 491841704
Bug: 475990372
Bug: 477170017
Bug: 474496110
Bug: 492693465
Bug: 494002968