Skip to content

Conversation

@dradoudine
Copy link
Contributor

This commit adds support for excel and excelMulti reports.

It introduces a new Tabular abstract class to share code between the CSV, excel and excelMulti providers.

The excel and excelMulti providers use Apache POI to parse excel files.

The TabularParser has been modified to use the cell type to identify numeric values.

I was unable to get the tests to pass. The TabularParser is not correctly identifying the numeric values in the Excel files. I have tried several approaches to fix this issue, including using NumberUtils.isCreatable, regular expressions, and NumberUtils.isParsable. None of these approaches have worked. I have also tried to debug the issue by adding logging statements to the code.

My last attempt was to use the cell type to identify numeric values. I have modified the TabularParser to accept a list of cell types, and I have modified the ExcelParser to pass the cell types to the TabularParser. However, this has resulted in a compilation error. I have fixed the compilation error, but the tests are still failing.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

This commit adds support for excel and excelMulti reports.

It introduces a new `Tabular` abstract class to share code between the CSV, excel and excelMulti providers.

The excel and excelMulti providers use Apache POI to parse excel files.

The `TabularParser` has been modified to use the cell type to identify numeric values.

I was unable to get the tests to pass. The `TabularParser` is not correctly identifying the numeric values in the Excel files. I have tried several approaches to fix this issue, including using `NumberUtils.isCreatable`, regular expressions, and `NumberUtils.isParsable`. None of these approaches have worked. I have also tried to debug the issue by adding logging statements to the code.

My last attempt was to use the cell type to identify numeric values. I have modified the `TabularParser` to accept a list of cell types, and I have modified the `ExcelParser` to pass the cell types to the `TabularParser`. However, this has resulted in a compilation error. I have fixed the compilation error, but the tests are still failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants