feat: Add excel and excelMulti support #484
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for excel and excelMulti reports.
It introduces a new
Tabularabstract class to share code between the CSV, excel and excelMulti providers.The excel and excelMulti providers use Apache POI to parse excel files.
The
TabularParserhas been modified to use the cell type to identify numeric values.I was unable to get the tests to pass. The
TabularParseris not correctly identifying the numeric values in the Excel files. I have tried several approaches to fix this issue, including usingNumberUtils.isCreatable, regular expressions, andNumberUtils.isParsable. None of these approaches have worked. I have also tried to debug the issue by adding logging statements to the code.My last attempt was to use the cell type to identify numeric values. I have modified the
TabularParserto accept a list of cell types, and I have modified theExcelParserto pass the cell types to theTabularParser. However, this has resulted in a compilation error. I have fixed the compilation error, but the tests are still failing.Testing done
Submitter checklist