Skip to content

Commit 458bf27

Browse files
committed
Reuse completed build result
Instead of invoking `completedRun.getResult()` several times, invoke it once and reuse the resust. That makes the code slightly easier to read.
1 parent b3ba0a8 commit 458bf27

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,18 +178,19 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
178178
+ " started.");
179179

180180
Run completedRun = future.get();
181+
Result completedResult = completedRun.getResult();
181182
listener.getLogger()
182183
.println(HyperlinkNote.encodeTo(
183184
'/' + completedRun.getUrl(), completedRun.getFullDisplayName())
184-
+ " completed. Result was " + completedRun.getResult());
185+
+ " completed. Result was " + completedResult);
185186
BuildInfoExporterAction.addBuildInfoExporterAction(
186187
build,
187188
completedRun.getParent().getFullName(),
188189
completedRun.getNumber(),
189-
completedRun.getResult());
190+
completedResult);
190191

191-
if (buildStepResult && config.getBlock().mapBuildStepResult(completedRun.getResult())) {
192-
Result r = config.getBlock().mapBuildResult(completedRun.getResult());
192+
if (buildStepResult && config.getBlock().mapBuildStepResult(completedResult)) {
193+
Result r = config.getBlock().mapBuildResult(completedResult);
193194
if (r != null) { // The blocking job is not a success
194195
build.setResult(r);
195196
}

0 commit comments

Comments
 (0)