Skip to content

Commit f60b7e3

Browse files
committed
Reuse completed build result
Instead of invoking `completedRun.getResult()` several times, invoke it once and reuse the resust. That makes the code slightly easier to read.
1 parent aa92dfe commit f60b7e3

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,20 +179,21 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
179179
+ " started.");
180180

181181
Run completedRun = future.get();
182+
Result completedResult = completedRun.getResult();
182183
listener.getLogger()
183184
.println(HyperlinkNote.encodeTo(
184185
'/' + completedRun.getUrl(),
185186
completedRun.getFullDisplayName())
186-
+ " completed. Result was " + completedRun.getResult());
187+
+ " completed. Result was " + completedResult);
187188
BuildInfoExporterAction.addBuildInfoExporterAction(
188189
build,
189190
completedRun.getParent().getFullName(),
190191
completedRun.getNumber(),
191-
completedRun.getResult());
192+
completedResult);
192193

193194
if (buildStepResult
194-
&& config.getBlock().mapBuildStepResult(completedRun.getResult())) {
195-
Result r = config.getBlock().mapBuildResult(completedRun.getResult());
195+
&& config.getBlock().mapBuildStepResult(completedResult)) {
196+
Result r = config.getBlock().mapBuildResult(completedResult);
196197
if (r != null) { // The blocking job is not a success
197198
build.setResult(r);
198199
}

0 commit comments

Comments
 (0)