From 67ea9af5a515e12af528366200410b26c805cf88 Mon Sep 17 00:00:00 2001 From: jslee Date: Mon, 22 Jun 2020 19:39:42 +0900 Subject: [PATCH 1/8] start study --- src/main/java/Main.java | 27 +++++++++++++++++++++++++++ src/main/java/method1.md | 0 2 files changed, 27 insertions(+) create mode 100644 src/main/java/Main.java create mode 100644 src/main/java/method1.md diff --git a/src/main/java/Main.java b/src/main/java/Main.java new file mode 100644 index 0000000..07303f3 --- /dev/null +++ b/src/main/java/Main.java @@ -0,0 +1,27 @@ +import java.util.ArrayList; +import java.util.List; + +public class Main { + public static void main(String[] args) { + Computer c = new Computer(); + c.initNumber(); + System.out.println(c.initNumber()); + } + static class Computer { + private List initNumber() { + List number = new ArrayList<>(); + for (int i = 0; i < 3; i++) { + int randomNum = (int) (Math.random()*10); + number.add(randomNum); + } + return number; + } + private String checkNumber(Integer userNumber, List computerNum) { + + + + return ""; + } + } + +} diff --git a/src/main/java/method1.md b/src/main/java/method1.md new file mode 100644 index 0000000..e69de29 From 8746379a38165f78393d4f26b7a16887f37d42a2 Mon Sep 17 00:00:00 2001 From: jslee Date: Thu, 25 Jun 2020 17:15:34 +0900 Subject: [PATCH 2/8] =?UTF-8?q?=EA=B2=8C=EC=9E=84=20=EC=99=84=EC=84=B1?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/java/Main.java | 79 +++++++++++++++++++++++++++++++++-------- 1 file changed, 65 insertions(+), 14 deletions(-) diff --git a/src/main/java/Main.java b/src/main/java/Main.java index 07303f3..2c57056 100644 --- a/src/main/java/Main.java +++ b/src/main/java/Main.java @@ -1,27 +1,78 @@ -import java.util.ArrayList; -import java.util.List; +import java.util.Scanner; public class Main { public static void main(String[] args) { Computer c = new Computer(); - c.initNumber(); - System.out.println(c.initNumber()); - } - static class Computer { - private List initNumber() { - List number = new ArrayList<>(); - for (int i = 0; i < 3; i++) { - int randomNum = (int) (Math.random()*10); - number.add(randomNum); + Boolean scannerChk = true; + String userInput = ""; + System.out.println("1부터 9까지로 이루어진 숫자 3개를 눌러주세요.\n더 이상 게임을 원하지 않을경우 000 을 입력하세요."); + while (scannerChk) { + String computerInput = c.initNumber(); + Scanner sc = new Scanner(System.in); + System.out.println("숫자를 입력하세요."); + userInput = sc.next(); + if (userInput.equals("000")) { + scannerChk = false; + break; + } + if (userInput.length() != 3) { + System.out.println("숫자를 다시 입력해주세요."); + continue; } - return number; + System.out.println(c.checkNumber(userInput, computerInput)); + System.out.println("상대방 숫자는 " + computerInput + "입니다."); + } - private String checkNumber(Integer userNumber, List computerNum) { + System.out.println("게임이 종료됐습니다. 감사합니다."); + } + static class Computer { + private String initNumber() { + return getRandomInteger(9, 1, 3); + } + + public static String getRandomInteger(int maximum, int minimum, int length) { + String res = ""; + for (int i = 0; i < length; i++) { + res += ((int) (Math.random() * (maximum - minimum))) + minimum; + } + return res; + } + private String checkNumber(String userNumber, String computerNum) { + int bcnt = 0; + int scnt = 0; + int cn = Integer.parseInt(computerNum); + for (int i = 0; i < computerNum.length(); i++) { + String kcn = cn % 10 + ""; + int chk = reverseStr(userNumber).lastIndexOf(kcn); + if (chk > -1 && chk != i) { + bcnt++; + } + if (chk == i) { + scnt++; + } + cn = cn / 10; + } + return result(bcnt, scnt); + } - return ""; + private String result(int bcnt, int scnt) { + String res = ""; + if (bcnt > 0) { + res += bcnt + " ball "; + } + if (scnt > 0) { + res += scnt + " strike"; + } + if (bcnt == 0 && scnt == 0) { + res = "nothing"; + } + return res; } } + public static String reverseStr(String s) { + return (new StringBuffer(s)).reverse().toString(); + } } From 6e47729d0c4f5bf3988d3be944490ed1044379e8 Mon Sep 17 00:00:00 2001 From: jslee Date: Thu, 25 Jun 2020 17:36:30 +0900 Subject: [PATCH 3/8] =?UTF-8?q?=EC=BD=94=EB=93=9C=20=EC=A0=95=EB=A6=AC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/java/Main.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/main/java/Main.java b/src/main/java/Main.java index 2c57056..1324fe0 100644 --- a/src/main/java/Main.java +++ b/src/main/java/Main.java @@ -3,16 +3,14 @@ public class Main { public static void main(String[] args) { Computer c = new Computer(); - Boolean scannerChk = true; String userInput = ""; System.out.println("1부터 9까지로 이루어진 숫자 3개를 눌러주세요.\n더 이상 게임을 원하지 않을경우 000 을 입력하세요."); - while (scannerChk) { + while (true) { String computerInput = c.initNumber(); Scanner sc = new Scanner(System.in); System.out.println("숫자를 입력하세요."); userInput = sc.next(); if (userInput.equals("000")) { - scannerChk = false; break; } if (userInput.length() != 3) { @@ -21,7 +19,6 @@ public static void main(String[] args) { } System.out.println(c.checkNumber(userInput, computerInput)); System.out.println("상대방 숫자는 " + computerInput + "입니다."); - } System.out.println("게임이 종료됐습니다. 감사합니다."); } From 61e6f505c9a3a89b9383cadecbaa69ac850d37bc Mon Sep 17 00:00:00 2001 From: jslee Date: Thu, 25 Jun 2020 17:38:31 +0900 Subject: [PATCH 4/8] =?UTF-8?q?=EC=BD=94=EB=93=9C=20=EC=A0=95=EB=A6=AC2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/java/Main.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/Main.java b/src/main/java/Main.java index 1324fe0..79c0742 100644 --- a/src/main/java/Main.java +++ b/src/main/java/Main.java @@ -17,8 +17,8 @@ public static void main(String[] args) { System.out.println("숫자를 다시 입력해주세요."); continue; } - System.out.println(c.checkNumber(userInput, computerInput)); System.out.println("상대방 숫자는 " + computerInput + "입니다."); + System.out.println(c.checkNumber(userInput, computerInput)); } System.out.println("게임이 종료됐습니다. 감사합니다."); } From f8da82f2cbd9f0fd4fdd1ffe340f453f7e15cc83 Mon Sep 17 00:00:00 2001 From: jslee Date: Sun, 28 Jun 2020 20:40:16 +0900 Subject: [PATCH 5/8] =?UTF-8?q?=EC=95=BC=EA=B5=AC=EA=B2=8C=EC=9E=84=20?= =?UTF-8?q?=EC=A0=95=EB=A6=AC.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. 생성자 2. 서비스 --- src/main/java/Baseball.java | 22 +++++++ src/main/java/BaseballService.java | 8 +++ src/main/java/BaseballServiceImpl.java | 87 ++++++++++++++++++++++++++ src/main/java/Main.java | 64 ++----------------- 4 files changed, 122 insertions(+), 59 deletions(-) create mode 100644 src/main/java/Baseball.java create mode 100644 src/main/java/BaseballService.java create mode 100644 src/main/java/BaseballServiceImpl.java diff --git a/src/main/java/Baseball.java b/src/main/java/Baseball.java new file mode 100644 index 0000000..47e86ca --- /dev/null +++ b/src/main/java/Baseball.java @@ -0,0 +1,22 @@ +public class Baseball { + private String comNumber; + private String userNumber; + + public String getComNumber() { + return comNumber; + } + + public void setComNumber(String comNumber) { + this.comNumber = comNumber; + } + + public String getUserNumber() { + return userNumber; + } + + public void setUserNumber(String userNumber) { + this.userNumber = userNumber; + } + + +} diff --git a/src/main/java/BaseballService.java b/src/main/java/BaseballService.java new file mode 100644 index 0000000..8287c71 --- /dev/null +++ b/src/main/java/BaseballService.java @@ -0,0 +1,8 @@ +public interface BaseballService { + String playGame(String userInput); + String checkNumber(String userNumber, String comNumber); + String result(int bnt, int cnt); + Boolean gameQuit(String userNumber); + Boolean isInt(String userNumber); + Boolean checkLength(String userNumber); +} diff --git a/src/main/java/BaseballServiceImpl.java b/src/main/java/BaseballServiceImpl.java new file mode 100644 index 0000000..815c419 --- /dev/null +++ b/src/main/java/BaseballServiceImpl.java @@ -0,0 +1,87 @@ +public class BaseballServiceImpl implements BaseballService { + + @Override + public String playGame(String userNumber) { + Baseball b = new Baseball(); + b.setComNumber(getRandomInteger(9, 1, 3)); + b.setUserNumber(userNumber); + System.out.println("상대방 숫자는 " + b.getComNumber() + "입니다."); + return checkNumber(b.getUserNumber(), b.getComNumber()); + } + + @Override + public String checkNumber(String userNumber, String comNumber) { + int bcnt = 0; + int scnt = 0; + int cn = Integer.parseInt(comNumber); + for (int i = 0; i < comNumber.length(); i++) { + String kcn = cn % 10 + ""; + int chk = reverseStr(userNumber).lastIndexOf(kcn); + if (chk > -1 && chk != i) { + bcnt++; + } + if (chk == i) { + scnt++; + } + cn = cn / 10; + } + return result(bcnt, scnt); + } + + @Override + public Boolean checkLength(String userNumber) { + if (userNumber.length() != 3) { + System.out.println("세자리 수를 입력해주세요."); + return false; + } + return true; + } + + @Override + public Boolean gameQuit(String userNumber) { + if (userNumber.equals("000")) { + return false; + } + return true; + } + + @Override + public Boolean isInt(String userNumber) { + try { + Integer.parseInt(userNumber); + return true; + } catch (NumberFormatException e) { + System.out.println("문자는 안됩니다. 숫자를 입력하세요."); + return false; + } + + } + + @Override + public String result(int bCnt, int sCnt) { + String res = ""; + if (bCnt > 0) { + res += bCnt + " ball "; + } + if (sCnt > 0) { + res += sCnt + " strike"; + } + if (bCnt == 0 && sCnt == 0) { + res = "nothing"; + } + return res; + } + + public String getRandomInteger(int maximum, int minimum, int length) { + String res = ""; + for (int i = 0; i < length; i++) { + res += ((int) (Math.random() * (maximum - minimum))) + minimum; + } + return res; + } + + + public static String reverseStr(String s) { + return (new StringBuffer(s)).reverse().toString(); + } +} diff --git a/src/main/java/Main.java b/src/main/java/Main.java index 79c0742..f32dc11 100644 --- a/src/main/java/Main.java +++ b/src/main/java/Main.java @@ -2,74 +2,20 @@ public class Main { public static void main(String[] args) { - Computer c = new Computer(); - String userInput = ""; + BaseballService bs = new BaseballServiceImpl(); System.out.println("1부터 9까지로 이루어진 숫자 3개를 눌러주세요.\n더 이상 게임을 원하지 않을경우 000 을 입력하세요."); while (true) { - String computerInput = c.initNumber(); Scanner sc = new Scanner(System.in); System.out.println("숫자를 입력하세요."); - userInput = sc.next(); - if (userInput.equals("000")) { + String userNumber = sc.next(); + if (!bs.gameQuit(userNumber)) { break; } - if (userInput.length() != 3) { - System.out.println("숫자를 다시 입력해주세요."); + if (!bs.isInt(userNumber) || !bs.checkLength(userNumber)) { continue; } - System.out.println("상대방 숫자는 " + computerInput + "입니다."); - System.out.println(c.checkNumber(userInput, computerInput)); + System.out.println(bs.playGame(userNumber)); } System.out.println("게임이 종료됐습니다. 감사합니다."); } - - static class Computer { - private String initNumber() { - return getRandomInteger(9, 1, 3); - } - - public static String getRandomInteger(int maximum, int minimum, int length) { - String res = ""; - for (int i = 0; i < length; i++) { - res += ((int) (Math.random() * (maximum - minimum))) + minimum; - } - return res; - } - - private String checkNumber(String userNumber, String computerNum) { - int bcnt = 0; - int scnt = 0; - int cn = Integer.parseInt(computerNum); - for (int i = 0; i < computerNum.length(); i++) { - String kcn = cn % 10 + ""; - int chk = reverseStr(userNumber).lastIndexOf(kcn); - if (chk > -1 && chk != i) { - bcnt++; - } - if (chk == i) { - scnt++; - } - cn = cn / 10; - } - return result(bcnt, scnt); - } - - private String result(int bcnt, int scnt) { - String res = ""; - if (bcnt > 0) { - res += bcnt + " ball "; - } - if (scnt > 0) { - res += scnt + " strike"; - } - if (bcnt == 0 && scnt == 0) { - res = "nothing"; - } - return res; - } - } - - public static String reverseStr(String s) { - return (new StringBuffer(s)).reverse().toString(); - } } From 693f7460ec9c685c530e40cb54e6e2001d03f2a8 Mon Sep 17 00:00:00 2001 From: jslee Date: Sun, 28 Jun 2020 21:26:21 +0900 Subject: [PATCH 6/8] =?UTF-8?q?=EC=95=BC=EA=B5=AC=EA=B2=8C=EC=9E=84=20?= =?UTF-8?q?=EC=BD=94=EB=93=9C=20=EC=A0=95=EB=A6=AC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. 컴퓨터가 서로 다른 수를 정할 수 있도록 코드 정리 2. service 로 만들지 않아도 되는 것들을 정리 --- src/main/java/Baseball.java | 2 -- src/main/java/BaseballService.java | 2 -- src/main/java/BaseballServiceImpl.java | 45 ++++++++++++++------------ 3 files changed, 24 insertions(+), 25 deletions(-) diff --git a/src/main/java/Baseball.java b/src/main/java/Baseball.java index 47e86ca..c5a1a9f 100644 --- a/src/main/java/Baseball.java +++ b/src/main/java/Baseball.java @@ -17,6 +17,4 @@ public String getUserNumber() { public void setUserNumber(String userNumber) { this.userNumber = userNumber; } - - } diff --git a/src/main/java/BaseballService.java b/src/main/java/BaseballService.java index 8287c71..8a479f0 100644 --- a/src/main/java/BaseballService.java +++ b/src/main/java/BaseballService.java @@ -1,7 +1,5 @@ public interface BaseballService { String playGame(String userInput); - String checkNumber(String userNumber, String comNumber); - String result(int bnt, int cnt); Boolean gameQuit(String userNumber); Boolean isInt(String userNumber); Boolean checkLength(String userNumber); diff --git a/src/main/java/BaseballServiceImpl.java b/src/main/java/BaseballServiceImpl.java index 815c419..504f7e1 100644 --- a/src/main/java/BaseballServiceImpl.java +++ b/src/main/java/BaseballServiceImpl.java @@ -9,24 +9,6 @@ public String playGame(String userNumber) { return checkNumber(b.getUserNumber(), b.getComNumber()); } - @Override - public String checkNumber(String userNumber, String comNumber) { - int bcnt = 0; - int scnt = 0; - int cn = Integer.parseInt(comNumber); - for (int i = 0; i < comNumber.length(); i++) { - String kcn = cn % 10 + ""; - int chk = reverseStr(userNumber).lastIndexOf(kcn); - if (chk > -1 && chk != i) { - bcnt++; - } - if (chk == i) { - scnt++; - } - cn = cn / 10; - } - return result(bcnt, scnt); - } @Override public Boolean checkLength(String userNumber) { @@ -57,7 +39,24 @@ public Boolean isInt(String userNumber) { } - @Override + public String checkNumber(String userNumber, String comNumber) { + int bcnt = 0; + int scnt = 0; + int cn = Integer.parseInt(comNumber); + for (int i = 0; i < comNumber.length(); i++) { + String kcn = cn % 10 + ""; + int chk = reverseStr(userNumber).lastIndexOf(kcn); + if (chk > -1 && chk != i) { + bcnt++; + } + if (chk == i) { + scnt++; + } + cn = cn / 10; + } + return result(bcnt, scnt); + } + public String result(int bCnt, int sCnt) { String res = ""; if (bCnt > 0) { @@ -74,8 +73,11 @@ public String result(int bCnt, int sCnt) { public String getRandomInteger(int maximum, int minimum, int length) { String res = ""; - for (int i = 0; i < length; i++) { - res += ((int) (Math.random() * (maximum - minimum))) + minimum; + while(!(res.length() == length)) { + int num = ((int) (Math.random() * (maximum - minimum))) + minimum; + if (res.indexOf(num + "") == -1) { + res +=num; + } } return res; } @@ -85,3 +87,4 @@ public static String reverseStr(String s) { return (new StringBuffer(s)).reverse().toString(); } } + From cefdd02bedbf8d20e9db43c2f381d4e5e624f5ed Mon Sep 17 00:00:00 2001 From: jslee Date: Thu, 9 Jul 2020 12:12:48 +0900 Subject: [PATCH 7/8] =?UTF-8?q?=ED=94=BC=EB=93=9C=EB=B0=B1=20=EB=B0=9B?= =?UTF-8?q?=EC=9D=80=EA=B1=B0=20=EC=A0=95=EB=A6=AC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. 축약된 변수명 변경 bs -> baseballGame, bcnt -> ballCnt, scnt -> strikeCnt 2. 상수화 private final 로 변경 3. BaseballService 의 이름 변경 SportsGameService 로 이름 변경 이유 : 나중에 야구 말고 다른게임이 나왔을경우 확장하고 싶어서 --- src/main/java/BaseballServiceImpl.java | 44 ++++++++++--------- src/main/java/Main.java | 8 ++-- ...allService.java => SportsGameService.java} | 3 +- 3 files changed, 29 insertions(+), 26 deletions(-) rename src/main/java/{BaseballService.java => SportsGameService.java} (53%) diff --git a/src/main/java/BaseballServiceImpl.java b/src/main/java/BaseballServiceImpl.java index 504f7e1..129e601 100644 --- a/src/main/java/BaseballServiceImpl.java +++ b/src/main/java/BaseballServiceImpl.java @@ -1,4 +1,4 @@ -public class BaseballServiceImpl implements BaseballService { +public class BaseballServiceImpl implements SportsGameService { @Override public String playGame(String userNumber) { @@ -9,69 +9,71 @@ public String playGame(String userNumber) { return checkNumber(b.getUserNumber(), b.getComNumber()); } - + private final Integer NUM_DIGIT = 3; + private final String OVER_DIGIT_MESSAGE = "세자리 수를 입력해주세요."; @Override public Boolean checkLength(String userNumber) { - if (userNumber.length() != 3) { - System.out.println("세자리 수를 입력해주세요."); + if (userNumber.length() != NUM_DIGIT) { + System.out.println(OVER_DIGIT_MESSAGE); return false; } return true; } - + private final Integer GAME_QUIT = 000; @Override public Boolean gameQuit(String userNumber) { - if (userNumber.equals("000")) { + if (userNumber.equals(GAME_QUIT)) { return false; } return true; } + private final String NOT_INT_MESSAGE = "문자는 안됩니다. 숫자를 입력하세요."; @Override public Boolean isInt(String userNumber) { try { Integer.parseInt(userNumber); return true; } catch (NumberFormatException e) { - System.out.println("문자는 안됩니다. 숫자를 입력하세요."); + System.out.println(NOT_INT_MESSAGE); return false; } } - public String checkNumber(String userNumber, String comNumber) { - int bcnt = 0; - int scnt = 0; + private String checkNumber(String userNumber, String comNumber) { + int ballCount = 0; + int strikeCount = 0; int cn = Integer.parseInt(comNumber); for (int i = 0; i < comNumber.length(); i++) { String kcn = cn % 10 + ""; int chk = reverseStr(userNumber).lastIndexOf(kcn); if (chk > -1 && chk != i) { - bcnt++; + ballCount++; } if (chk == i) { - scnt++; + strikeCount++; } cn = cn / 10; } - return result(bcnt, scnt); + return result(ballCount, strikeCount); } - public String result(int bCnt, int sCnt) { + private String result(int ballCount, int strikeCount) { String res = ""; - if (bCnt > 0) { - res += bCnt + " ball "; + if (ballCount > 0) { + res += ballCount + " ball "; } - if (sCnt > 0) { - res += sCnt + " strike"; + if (strikeCount > 0) { + res += strikeCount + " strike"; } - if (bCnt == 0 && sCnt == 0) { + if (ballCount == 0 && strikeCount == 0) { res = "nothing"; } return res; } - public String getRandomInteger(int maximum, int minimum, int length) { + private String getRandomInteger(int maximum, int minimum, int length) { String res = ""; while(!(res.length() == length)) { int num = ((int) (Math.random() * (maximum - minimum))) + minimum; @@ -83,7 +85,7 @@ public String getRandomInteger(int maximum, int minimum, int length) { } - public static String reverseStr(String s) { + private static String reverseStr(String s) { return (new StringBuffer(s)).reverse().toString(); } } diff --git a/src/main/java/Main.java b/src/main/java/Main.java index f32dc11..daa4fc8 100644 --- a/src/main/java/Main.java +++ b/src/main/java/Main.java @@ -2,19 +2,19 @@ public class Main { public static void main(String[] args) { - BaseballService bs = new BaseballServiceImpl(); + SportsGameService baseballGame = new BaseballServiceImpl(); System.out.println("1부터 9까지로 이루어진 숫자 3개를 눌러주세요.\n더 이상 게임을 원하지 않을경우 000 을 입력하세요."); while (true) { Scanner sc = new Scanner(System.in); System.out.println("숫자를 입력하세요."); String userNumber = sc.next(); - if (!bs.gameQuit(userNumber)) { + if (!baseballGame.gameQuit(userNumber)) { break; } - if (!bs.isInt(userNumber) || !bs.checkLength(userNumber)) { + if (!baseballGame.isInt(userNumber) || !baseballGame.checkLength(userNumber)) { continue; } - System.out.println(bs.playGame(userNumber)); + System.out.println(baseballGame.playGame(userNumber)); } System.out.println("게임이 종료됐습니다. 감사합니다."); } diff --git a/src/main/java/BaseballService.java b/src/main/java/SportsGameService.java similarity index 53% rename from src/main/java/BaseballService.java rename to src/main/java/SportsGameService.java index 8a479f0..fe7688a 100644 --- a/src/main/java/BaseballService.java +++ b/src/main/java/SportsGameService.java @@ -1,4 +1,5 @@ -public interface BaseballService { +public interface SportsGameService { +// baseball game 뿐만 아니라 나중에 soccer 등의 확장성으 고려해 service 로 만듦 String playGame(String userInput); Boolean gameQuit(String userNumber); Boolean isInt(String userNumber); From bea2669912ff820f16930cd08d23726b0e5bf47a Mon Sep 17 00:00:00 2001 From: jslee Date: Thu, 9 Jul 2020 13:18:40 +0900 Subject: [PATCH 8/8] =?UTF-8?q?=EC=83=81=EC=88=98=ED=99=94=20=EA=B4=80?= =?UTF-8?q?=EB=A0=A8=20=EC=BD=94=EB=93=9C=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. static 추가 --- src/main/java/BaseballServiceImpl.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/BaseballServiceImpl.java b/src/main/java/BaseballServiceImpl.java index 129e601..790b791 100644 --- a/src/main/java/BaseballServiceImpl.java +++ b/src/main/java/BaseballServiceImpl.java @@ -9,8 +9,8 @@ public String playGame(String userNumber) { return checkNumber(b.getUserNumber(), b.getComNumber()); } - private final Integer NUM_DIGIT = 3; - private final String OVER_DIGIT_MESSAGE = "세자리 수를 입력해주세요."; + private static final Integer NUM_DIGIT = 3; + private static final String OVER_DIGIT_MESSAGE = "세자리 수를 입력해주세요."; @Override public Boolean checkLength(String userNumber) { if (userNumber.length() != NUM_DIGIT) { @@ -19,7 +19,7 @@ public Boolean checkLength(String userNumber) { } return true; } - private final Integer GAME_QUIT = 000; + private static final Integer GAME_QUIT = 000; @Override public Boolean gameQuit(String userNumber) { if (userNumber.equals(GAME_QUIT)) { @@ -28,7 +28,7 @@ public Boolean gameQuit(String userNumber) { return true; } - private final String NOT_INT_MESSAGE = "문자는 안됩니다. 숫자를 입력하세요."; + private static final String NOT_INT_MESSAGE = "문자는 안됩니다. 숫자를 입력하세요."; @Override public Boolean isInt(String userNumber) { try { @@ -85,7 +85,7 @@ private String getRandomInteger(int maximum, int minimum, int length) { } - private static String reverseStr(String s) { + private String reverseStr(String s) { return (new StringBuffer(s)).reverse().toString(); } }