Adding separate exception for http error. Inherits from ApiMetaError #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which ApiError also inherits from. rename ApiMetaError to ApiBaseError
ms5
force-pushed
the
http_error_code_metaclass
branch
from
5269bc8 to
7a37483
Compare
Contributor
Author
|
I renamed the base exception to ApiBaseError which is IMHO more adequate about what is is, than "meta" exception which is misleading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal of handling api and http errors according to discussion of pr #43
includes two separate classes for api and http errors, but both exceptions are inherited from a ApiMetaError exception.