Stop inflecting API method parameters on each call #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, every parameter of an API call was converted to camel case before being serialized to JSON - even if it had been converted before. This added unnecessary overhead to every API call.This avoids these conversions by manually constructing dicts with the correct keys from the parameters passed to the method.
Contributor
Author
|
The flake8 errors are unrelated to the changes in this PR, #54 will fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, every parameter of an API call was converted to camel case before
being serialized to JSON - even if it had been converted before. This added
unnecessary overhead to every API call.This avoids these conversions by
manually constructing dicts with the correct keys from the parameters passed
to the method.
This is a little less pretty but is the most straight forward way of achieving this.
The code passes flake8 checks, but if there are any formatting changes you would
like I will happily make them.