rexml 3.4.3 causes test failures

[mattwd7]

The latest rexml gem version 3.4.3 causes the crack tests to fail with 2 errors:

  1) Error:
Crack::XML#test_0035_handle an xml string containing a single space:
REXML::ParseException: Malformed XML: No root element
Line: 1
Position: 1
Last 80 unconsumed characters:

    /Users/user.name/.rbenv/versions/3.2.8/lib/ruby/gems/3.2.0/gems/rexml-3.4.3/lib/rexml/parsers/baseparser.rb:271:in `pull_event'
    /Users/user.name/.rbenv/versions/3.2.8/lib/ruby/gems/3.2.0/gems/rexml-3.4.3/lib/rexml/parsers/baseparser.rb:249:in `pull'
    lib/crack/xml.rb:203:in `parse'
    lib/crack/xml.rb:235:in `parse'
    test/xml_test.rb:490:in `block (2 levels) in <top (required)>'

  2) Error:
Crack::XML#test_0034_handle an empty xml string:
REXML::ParseException: Malformed XML: No root element
Line: 0
Position: 0
Last 80 unconsumed characters:

    /Users/user.name/.rbenv/versions/3.2.8/lib/ruby/gems/3.2.0/gems/rexml-3.4.3/lib/rexml/parsers/baseparser.rb:271:in `pull_event'
    /Users/user.name/.rbenv/versions/3.2.8/lib/ruby/gems/3.2.0/gems/rexml-3.4.3/lib/rexml/parsers/baseparser.rb:249:in `pull'
    lib/crack/xml.rb:203:in `parse'
    lib/crack/xml.rb:235:in `parse'
    test/xml_test.rb:485:in `block (2 levels) in <top (required)>'

92 runs, 160 assertions, 0 failures, 2 errors, 0 skips

This is consistent with the rexml release notes:

Reject no root element XML as an invalid XML

[kiskoza]

Hey, thanks for reporting it! I've made a PR to keep existing behaviour (giving back empty hash). Let me know, if you find this solution useful and then I can merge in and initiate a new release

[mattwd7]

Can I request the creation of a new release that incorporates this change? cc @kiskoza

[mattwd7]

I see the new tag for 1.0.1, but attempting to update the gem in my project suggests the release has not been pushed to rubygems.org

[kiskoza]

yes, I know about this, sorry for the delay. unfortunately I don't have direct access to rubygems yet, so I pinged the right people in #89. last time they made the release pretty quickly