Issue with SOAP api starting from v0.18.0

[Nechitadi]

Hello,

I've noticed that starting from version v0.18.0 there is an extra '/' added at the end of the request url. Is this something on purpose? Maybe it works for the REST api, but we are using SOAP api on our project and it does not accept '/' at the end.

Example of request with version 0.20.0:
<- "POST /LDBSVWS/ldbsv12.asmx/ HTTP/1.1\r\nContent-Type: text/xml\r\nAccept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3\r\nAccept: */*\r\nUser-Agent: Ruby\r\nConnection: close\r\nHost: [base_uri]\r\nContent-Length: 534\r\n\r\n"
Response: -> "HTTP/1.1 500 Internal Server Error\r\n"

Example of request with version 0.17.0:
<- "POST /LDBSVWS/ldbsv12.asmx HTTP/1.1\r\nContent-Type: text/xml\r\nConnection: close\r\nHost: [base_uri]\r\nContent-Length: 534\r\n\r\n"` Response: `-> "HTTP/1.1 200 OK\r\n"

So the differences that I notice between the working example and the non working one are:

• the NON working one contains a '/' after 'ldbsv12.asmx/'
• that the NON working example contains Accept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3\r\nAccept: */*\r\nUser-Agent: Ruby\r\n while the working one doesn't

[jnunemaker]

@Nechitadi I can't replicate this. Can you get me a failing script or spec? If you change the uri adapter to addressable does it work?

uri_adapter(Addressable::URI)

[Nechitadi]

Yes, it worked with the uri_adapter(Addressable::URI). Is there any way to set this option by default? Because we have multiple services that use HTTParty for soap. Or just by creating a base service and the other ones to inherit from there?

Thank you!

[jnunemaker]

Yep, you’ll need a base service or another include that sets the uri adapter.  Must be Ruby’s uri has an issue with this as that is the default uri adapter. 

On November 10, 2021, David Grevink ***@***.***> wrote: Yes, it worked with the uri_adapter(Addressable::URI). Is there any way to set this option by default? Because we have multiple services that use HTTParty for soap. Or just by creating a base service and the other ones to inherit from there?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <#742 (comment)- 964849688>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/AAAAB27WJ5R6NKVO6CLEYZDULIMKDANCNFSM5HUXXTDQ>.

[ozgun]

Hello,

We experience the same issue.

When we set the base URI with base_uri('http://example.com/api/articles') and make a GET request with the get method by passing an empty string('') as the path, then the URL is appended a forward slash and is converted to http://example.com/api/articles/.

get("")

As far as I traced down, the following change, which was introduced with this commit in version 0.17.1, is causing the issue. The following line in the path= method converts the empty string to / after the normalize method is called:

uri_adapter.parse(uri).normalize

As @jnunemaker suggested, changing the uri adapter to Addressable::URI seems to be fixing the issue:

Addressable::URI.parse("").normalize.path #=> ""

URI.parse("").normalize.path  #=> "/"

However, I wonder if we could solve this issue by skipping the normalization when the uri is an empty string by updating the path= method in lib/httparty/request.rb file as below:

def path=(uri)
  uri_adapter = options[:uri_adapter]

  @path = if uri.is_a?(uri_adapter)
    uri
  elsif String.try_convert(uri)
    if uri == ""
      uri_adapter.parse(uri)
    else
      uri_adapter.parse(uri).normalize
    end
  else
    raise ArgumentError,
      "bad argument (expected #{uri_adapter} object or URI string)"
  end
end

If you think this is a valid solution, I can create a PR, thanks!

[jnunemaker]

@ozgun Should we just move the normalize to the uri adapter? Then people could use whatever uri_adapter they want to normalize or not normalize. Thoughts? Yes, I'm open to PR to see the full scope of spec and code changes. :)