From 9fec2175a31e45d8fb104c464547998b964eb3bc Mon Sep 17 00:00:00 2001 From: caylabradleydev <124472388+caylabradleydev@users.noreply.github.com> Date: Sat, 30 Mar 2024 10:10:23 -0500 Subject: [PATCH] Update deprecated pageXOffset and pageYOffset pageXOffset and pageYOffset are deprecated and have been updated to scrollX and scrollY respectively. scrollX & scrollY do not work in Internet Explorer and older browsers. Conditional OR maintains compatibility in both modern and older browsers. --- 13-Advanced-DOM-Bankist/final/script.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/13-Advanced-DOM-Bankist/final/script.js b/13-Advanced-DOM-Bankist/final/script.js index a0015c55ee..28e05a3c0d 100644 --- a/13-Advanced-DOM-Bankist/final/script.js +++ b/13-Advanced-DOM-Bankist/final/script.js @@ -54,13 +54,13 @@ btnScrollTo.addEventListener('click', function (e) { // Scrolling // window.scrollTo( - // s1coords.left + window.pageXOffset, - // s1coords.top + window.pageYOffset + // s1coords.left + (window.scrollY || window.pageYOffSet), //pageXOffset is deprecated + // s1coords.top + (window.scrollY || window.pageYOffSet) //pageYOffset is deprecated // ); // window.scrollTo({ - // left: s1coords.left + window.pageXOffset, - // top: s1coords.top + window.pageYOffset, + // left: s1coords.left + (window.scrollX || window.pageXOffSet), //pageXOffset is deprecated + // top: s1coords.top + (window.scrollY || window.pageYOffSet), //pageYOffset is deprecated // behavior: 'smooth', // });