[bug] [regression] installer returned wrong download link for linux-amd64 assets

[IceCodeNew]

The latest commit was 746f746 when this bug been identified. And this is a regression bug.

To reproduce the bug, you may check the output script of https://i.jpillora.com/ouch-org/ouch?type=script:

	#choose from asset list
	URL=""
	FTYPE=""
	case "${OS}_${ARCH}" in
	"darwin_amd64")
		URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-x86_64-apple-darwin.tar.gz"
		FTYPE=".tar.gz"
		;;
	"linux_amd64")
		URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-armv7-unknown-linux-musleabihf.tar.gz"
		FTYPE=".tar.gz"
		;;
	"linux_arm64")
		URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-aarch64-unknown-linux-musl.tar.gz"
		FTYPE=".tar.gz"
		;;
	*) fail "No asset for platform ${OS}-${ARCH}";;
	esac

The commit 306c21e looks very suspicious to me.

[IceCodeNew]

here is the output of an instance runs on ghcr.io/jpillora/installer:0.6.2, which is working great.

	#choose from asset list
	URL=""
	FTYPE=""
	case "${OS}_${ARCH}" in
	"darwin_amd64")
		URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-x86_64-apple-darwin.tar.gz"
		FTYPE=".tar.gz"
		;;
	"linux_amd64")
		URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-x86_64-unknown-linux-musl.tar.gz"
		FTYPE=".tar.gz"
		;;
	"linux_arm")
		URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-armv7-unknown-linux-musleabihf.tar.gz"
		FTYPE=".tar.gz"
		;;
	"linux_arm64")
		URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-aarch64-unknown-linux-musl.tar.gz"
		FTYPE=".tar.gz"
		;;
	*) fail "No asset for platform ${OS}-${ARCH}";;
	esac

[jpillora]

Thanks for the report! Will fix

…

On Wed, 12 Mar 2025 at 4:32 am, IceCodeNew ***@***.***> wrote: https://installer.icecode.win/ouch-org/ouch?type=script runs on ghcr.io/jpillora/installer:0.6.2, which is working great. #choose from asset list URL="" FTYPE="" case "${OS}_${ARCH}" in "darwin_amd64") URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-x86_64-apple-darwin.tar.gz" FTYPE=".tar.gz" ;; "linux_amd64") URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-x86_64-unknown-linux-musl.tar.gz" FTYPE=".tar.gz" ;; "linux_arm") URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-armv7-unknown-linux-musleabihf.tar.gz" FTYPE=".tar.gz" ;; "linux_arm64") URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-aarch64-unknown-linux-musl.tar.gz" FTYPE=".tar.gz" ;; *) fail "No asset for platform ${OS}-${ARCH}";; esac — Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE2X45UOZ7ZP5TV5WGEQGL2T4M4NAVCNFSM6AAAAABYZNCBPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJVGE3DQMRYHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> [image: IceCodeNew]*IceCodeNew* left a comment (jpillora/installer#50) <#50 (comment)> https://installer.icecode.win/ouch-org/ouch?type=script runs on ghcr.io/jpillora/installer:0.6.2, which is working great. #choose from asset list URL="" FTYPE="" case "${OS}_${ARCH}" in "darwin_amd64") URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-x86_64-apple-darwin.tar.gz" FTYPE=".tar.gz" ;; "linux_amd64") URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-x86_64-unknown-linux-musl.tar.gz" FTYPE=".tar.gz" ;; "linux_arm") URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-armv7-unknown-linux-musleabihf.tar.gz" FTYPE=".tar.gz" ;; "linux_arm64") URL="https://github.com/ouch-org/ouch/releases/download/0.5.1/ouch-aarch64-unknown-linux-musl.tar.gz" FTYPE=".tar.gz" ;; *) fail "No asset for platform ${OS}-${ARCH}";; esac — Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE2X45UOZ7ZP5TV5WGEQGL2T4M4NAVCNFSM6AAAAABYZNCBPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJVGE3DQMRYHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[jpillora]

@IceCodeNew I’m on vacation atm - think you could fork, reproduce by adding your example to strings_test.go, and fix, then raise a PR?

I can merge and release from my iPhone :)