Skip to content

Conversation

@jrepp
Copy link
Owner

@jrepp jrepp commented Nov 20, 2025

User request: "look at all local branches for unmerged commits, create PRs if they are found by first merging origin/main and submitting the commit data"

This branch contains 1 unmerged commit(s). Conflicts resolved automatically with aggressive strategy.

Co-Authored-By: Claude noreply@anthropic.com

Removed 1,307 committed build output files from docs/ directory:
- All HTML files (ADRs, RFCs, MEMOs, user guide pages)
- All JavaScript bundles and assets (70,681 lines)
- All CSS files
- All JSON and XML files (search index, sitemap)

Preserved important non-generated assets:
- docs/img/ directory with 13 image files:
  - Prism logos (PNG, SVG)
  - Favicon and icons
  - Docusaurus default images
  - Social card image

Added docs/.gitignore to prevent future build output commits:
- Ignores *.html (all generated pages)
- Ignores specific generated directories (/adr/, /rfc/, /memos/, /user-guide/, etc.)
- Ignores /assets/css/ and /assets/js/ (generated bundles)
- Ignores search-index.json and sitemap.xml
- Explicitly allows /img/ directory and all images

Remaining tracked files in docs/:
- docs/.nojekyll (required by GitHub Pages)
- docs/.gitignore (newly added)
- docs/img/ (13 image files preserved)

Build output will be generated by CI via "docusaurus build --out-dir ../docs"
and published to GitHub Pages automatically. Source documentation remains in
docusaurus/docs/ and docs-cms/.
Copilot AI review requested due to automatic review settings November 20, 2025 22:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes generated documentation build output from the docs/ directory and establishes a .gitignore to prevent future commits of build artifacts. The changes ensure only source files and necessary GitHub Pages configuration are tracked, while all HTML, CSS, and JavaScript output is properly excluded.

Key Changes:

  • Removed all generated HTML documentation files from docs/adr/ directory
  • Added comprehensive .gitignore in docs/ directory to exclude build output
  • Preserves tracked assets like images in docs/img/ directory

Reviewed Changes

Copilot reviewed 17 out of 1307 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/adr/adr-013/index.html Removed generated HTML for Go Error Handling Strategy ADR
docs/adr/adr-015/index.html Removed generated HTML for Go Testing Strategy ADR
docs/adr/adr-016/index.html Removed generated HTML for Go CLI Configuration ADR
docs/adr/adr-017/index.html Removed generated HTML for Go Structured Logging ADR
docs/adr/adr-018/index.html Removed generated HTML for Rust Error Handling Strategy ADR
docs/.gitignore Added gitignore rules to exclude all build output while preserving source assets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify
Copy link

mergify bot commented Nov 20, 2025

This PR is very large (XL). Consider breaking it into smaller, more reviewable PRs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.59%. Comparing base (e862bec) to head (e509de9).

❗ There is a different number of reports uploaded between BASE (e862bec) and HEAD (e509de9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e862bec) HEAD (e509de9)
python-client 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #189       +/-   ##
===========================================
- Coverage   86.52%   30.59%   -55.94%     
===========================================
  Files          10        8        -2     
  Lines         631      572       -59     
  Branches       63        0       -63     
===========================================
- Hits          546      175      -371     
- Misses         77      397      +320     
+ Partials        8        0        -8     
Flag Coverage Δ
acceptance 30.59% <ø> (?)
integration 30.59% <ø> (?)
python-client ?
unittests 30.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving PR from repo owner

@mergify
Copy link

mergify bot commented Nov 20, 2025

🧪 CI Insights

Here's what we observed from your CI run for e509de9.

🟢 All jobs passed!

But CI Insights is watching 👀

@mergify mergify bot added the queued label Nov 20, 2025
mergify bot added a commit that referenced this pull request Nov 20, 2025
mergify bot added a commit that referenced this pull request Nov 20, 2025
@mergify
Copy link

mergify bot commented Nov 20, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #208.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added dequeued and removed queued labels Nov 20, 2025
@mergify
Copy link

mergify bot commented Nov 24, 2025

Merge Queue Status Beta

🚫 The pull request has left the queue (rule: default)

This pull request spent 1 hour 32 minutes 24 seconds in the queue, including 1 hour 31 minutes 27 seconds waiting for CI.
The checks were run on draft #208.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-neutral = PR Status Check
    • check-skipped = PR Status Check
    • check-success = PR Status Check
  • any of [🛡 GitHub repository ruleset rule]:
    • check-neutral = PR Status Check
    • check-skipped = PR Status Check
    • check-success = PR Status Check
  • #review-threads-unresolved = 0 [🛡 GitHub repository ruleset rule]

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the dequeued label Nov 25, 2025
@mergify
Copy link

mergify bot commented Nov 25, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 33 minutes 11 seconds in the queue, including 27 minutes 50 seconds waiting for CI.
The checks were run on draft #226.

Required conditions to merge
  • #review-threads-unresolved = 0 [🛡 GitHub repository ruleset rule]
  • any of [🛡 GitHub branch protection]:
    • check-success = PR Status Check
    • check-neutral = PR Status Check
    • check-skipped = PR Status Check
  • any of [🛡 GitHub repository ruleset rule]:
    • check-success = PR Status Check
    • check-neutral = PR Status Check
    • check-skipped = PR Status Check

@mergify mergify bot added the queued label Nov 25, 2025
mergify bot added a commit that referenced this pull request Nov 25, 2025
mergify bot added a commit that referenced this pull request Nov 25, 2025
@mergify mergify bot merged commit 891f9ef into main Nov 25, 2025
24 checks passed
@mergify mergify bot deleted the jrepp/cleanup-docs-build-output branch November 25, 2025 18:13
@mergify mergify bot removed the queued label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants