perf(replaceEntity): Removes extraneous db query.

Author: ryasmi

src/factory.test.ts

@@ -23,7 +23,7 @@ const tableName = 'testentities';
 before(async () => {
   const schema = (await db()).schema;
   await Promise.resolve(schema.dropTableIfExists(tableName));
-  await Promise.resolve(schema.createTableIfNotExists(tableName, async (table) => {
+  await Promise.resolve(schema.createTable(tableName, async (table) => {
     table.string('id').unique();
     table.string('stringProp');
     table.float('numberProp');

src/functions/replaceEntity.ts

@@ -1,16 +1,19 @@
+import MissingEntityError from '@js-entity-repos/core/dist/errors/MissingEntityError';
 import ReplaceEntity from '@js-entity-repos/core/dist/signatures/ReplaceEntity';
 import Entity from '@js-entity-repos/core/dist/types/Entity';
 import FacadeConfig from '../FacadeConfig';
 import constructIdFilter from '../utils/constructIdFilter';
 import filterEntities from '../utils/filterEntities';
-import getEntity from './getEntity';
 
 export default <E extends Entity>(config: FacadeConfig<E>): ReplaceEntity<E> => {
   return async ({ id, entity, filter = {} }) => {
     const table = (await config.db()).table(config.tableName);
     const document = config.constructDocument({ ...entity as any, id });
     const constructedFilter = constructIdFilter({ id, filter, config });
-    await Promise.resolve(filterEntities(table, constructedFilter).update(document));
-    return getEntity<E>(config)({ id, filter });
+    const res = await Promise.resolve(filterEntities(table, constructedFilter).update(document));
+    if (!res) {
+      throw new MissingEntityError(config.entityName, id);
+    }
+    return { entity };
   };
 };