From 615b48d0f5e4a0ecc86ca8af073f29ee5cb63eca Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 19:29:13 -0800
Subject: [PATCH 01/13] Split Build and Test steps in CI.

Make use of reusable GitHub workflows and matrix testing strategies.
---
 .github/workflows/lint.yml      |  8 ++--
 .github/workflows/test.yml      | 77 +++++++++++++++++++++------------
 .github/workflows/test_base.yml | 33 ++++++++++++++
 package.json                    |  9 ++--
 4 files changed, 92 insertions(+), 35 deletions(-)
 create mode 100644 .github/workflows/test_base.yml

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 3342e8bd..e7ee73b8 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -5,19 +5,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - name: use node.js v15.x
+      - name: use node.js v17.x
         uses: actions/setup-node@v1
         with:
-          node-version: 15.x
+          node-version: 17.x
       - run: npm ci --no-optional
       - run: npm run lint
   lint-unused-code: # look for unused functions and unused exports
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - name: use node.js v16.x
+      - name: use node.js v17.x
         uses: actions/setup-node@v1
         with:
-          node-version: 16.x
+          node-version: 17.x
       - run: npm ci --no-optional
       - run: npm run prune
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 2536e79b..e5b68ae3 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -5,36 +5,57 @@ on:
     branches:
       - main
 jobs:
-  test-node17:
-    runs-on: ubuntu-latest
+  test_demitasse_matrix:
+    strategy:
+      matrix:
+        version: [17.x, 16.x, 14.x]
     steps:
-      - uses: actions/checkout@v2
-      - name: use node.js v17.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 17.x
-      - run: npm ci --no-optional
-      - run: npm test
-  test-node16:
-    runs-on: ubuntu-latest
+    - uses: .github/workflows/test_base.yml
+      with:
+        node-version-for-testing: ${{ matrix.version }}
+        test-cmd: npm run test_nobuild
+  test_validstrings:
     steps:
-      - uses: actions/checkout@v2
-      - name: use node.js v16.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 16.x
-      - run: npm ci --no-optional
-      - run: npm test
-  test-node14:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - name: use node.js v14.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 14.x
-      - run: npm ci --no-optional
-      - run: npm test
+      uses: .github/workflows/test_base.yml
+      with:
+        node-version-for-testing: 17.x
+        test-cmd: npm run testValidStrings_nobuild
+
+  # test-node17:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #     - name: use node.js v17.x for build
+  #       uses: actions/setup-node@v1
+  #       with:
+  #         node-version: 17.x
+  #     - run: npm ci --no-optional
+
+  #     - name: use node.js v17.x for test
+  #       uses: actions/setup-node@v1
+  #       with:
+  #         node-version: 17.x
+  #     - run: npm test
+  # test-node16:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #     - name: use node.js v16.x
+  #       uses: actions/setup-node@v1
+  #       with:
+  #         node-version: 16.x
+  #     - run: npm ci --no-optional
+  #     - run: npm test
+  # test-node14:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #     - name: use node.js v14.x
+  #       uses: actions/setup-node@v1
+  #       with:
+  #         node-version: 14.x
+  #     - run: npm ci --no-optional
+  #     - run: npm test
   test-test262:
     runs-on: ubuntu-latest
     steps:
diff --git a/.github/workflows/test_base.yml b/.github/workflows/test_base.yml
new file mode 100644
index 00000000..5e0d1010
--- /dev/null
+++ b/.github/workflows/test_base.yml
@@ -0,0 +1,33 @@
+on:
+  workflow_call:
+    inputs:
+      node-version-for-testing:
+        required: false
+        default: 17.x # Should be the same as the verison used for builds below.
+        type: string
+      build-cmd:
+        required: false
+        default: npm run build
+        type: string
+      test-cmd:
+        required: true
+        type: string
+
+jobs:
+  reusable_workflow_job:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: use node.js v17.x for build
+        uses: actions/setup-node@v1
+        with:
+          node-version: lts/*
+      - run: npm ci --no-optional
+      - run: ${{ inputs.build-cmd }}
+      - name: use node.js for test execution
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ inputs.node-version-for-testing }}
+      - run: npm ci --no-optional
+      - run: ${{ test-cmd }}
+
diff --git a/package.json b/package.json
index aed9a264..87a5c3c6 100644
--- a/package.json
+++ b/package.json
@@ -24,9 +24,12 @@
   },
   "types": "./index.d.ts",
   "scripts": {
-    "test": "npm run build && node --no-warnings --experimental-modules --experimental-specifier-resolution=node --icu-data-dir node_modules/full-icu --loader ./test/resolve.source.mjs ./test/all.mjs",
-    "test262": "TEST262=1 npm run build && ./test/test262.sh",
-    "testValidStrings": "npm run build && node --experimental-modules --experimental-specifier-resolution=node --no-warnings --icu-data-dir ./node_modules/full-icu/ --loader ./test/resolve.source.mjs test/validStrings.mjs",
+    "test": "npm run build && npm run test_nobuild",
+    "test_nobuild": "node --no-warnings --experimental-modules --experimental-specifier-resolution=node --icu-data-dir node_modules/full-icu --loader ./test/resolve.source.mjs ./test/all.mjs",
+    "test262": "TEST262=1 npm run build && npm run test262_nobuild",
+    "test262_nobuild": "./test/test262.sh",
+    "testValidStrings": "npm run build && npm run testValidStrings_nobuild",
+    "testValidStrings_nobuild": "node --experimental-modules --experimental-specifier-resolution=node --no-warnings --icu-data-dir ./node_modules/full-icu/ --loader ./test/resolve.source.mjs test/validStrings.mjs",
     "build": "rm -rf dist/* tsc-out/* && tsc && rollup -c rollup.config.js",
     "prepare": "npm run build",
     "prepublishOnly": "node copy-types.mjs && npm run build",

From 8bfd727cc7d70b47531d04011144d449e2e1a4a6 Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 19:43:02 -0800
Subject: [PATCH 02/13] fixup! Split Build and Test steps in CI.

---
 .github/workflows/test.yml      | 51 ++++++---------------------------
 .github/workflows/test_base.yml |  4 +--
 2 files changed, 10 insertions(+), 45 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index e5b68ae3..ae93d09f 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -8,54 +8,21 @@ jobs:
   test_demitasse_matrix:
     strategy:
       matrix:
-        version: [17.x, 16.x, 14.x]
+        version:
+          - 17.x
+          - 16.x
+          - 14.x
     steps:
-    - uses: .github/workflows/test_base.yml
-      with:
-        node-version-for-testing: ${{ matrix.version }}
-        test-cmd: npm run test_nobuild
+      - uses: .github/workflows/test_base.yml
+        with:
+          node-version-for-testing: ${{ matrix.version }}
+          test-cmd: npm run test_nobuild
   test_validstrings:
     steps:
       uses: .github/workflows/test_base.yml
       with:
         node-version-for-testing: 17.x
         test-cmd: npm run testValidStrings_nobuild
-
-  # test-node17:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - uses: actions/checkout@v2
-  #     - name: use node.js v17.x for build
-  #       uses: actions/setup-node@v1
-  #       with:
-  #         node-version: 17.x
-  #     - run: npm ci --no-optional
-
-  #     - name: use node.js v17.x for test
-  #       uses: actions/setup-node@v1
-  #       with:
-  #         node-version: 17.x
-  #     - run: npm test
-  # test-node16:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - uses: actions/checkout@v2
-  #     - name: use node.js v16.x
-  #       uses: actions/setup-node@v1
-  #       with:
-  #         node-version: 16.x
-  #     - run: npm ci --no-optional
-  #     - run: npm test
-  # test-node14:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - uses: actions/checkout@v2
-  #     - name: use node.js v14.x
-  #       uses: actions/setup-node@v1
-  #       with:
-  #         node-version: 14.x
-  #     - run: npm ci --no-optional
-  #     - run: npm test
   test-test262:
     runs-on: ubuntu-latest
     steps:
@@ -100,7 +67,7 @@ jobs:
         env:
           HEAD_SHA: ${{ github.event.pull_request.head.sha }}
           NODE_ENV: production
-          TRANSPILE: '1'
+          TRANSPILE: "1"
   test-validstrings:
     runs-on: ubuntu-latest
     steps:
diff --git a/.github/workflows/test_base.yml b/.github/workflows/test_base.yml
index 5e0d1010..8d51d6d3 100644
--- a/.github/workflows/test_base.yml
+++ b/.github/workflows/test_base.yml
@@ -3,7 +3,7 @@ on:
     inputs:
       node-version-for-testing:
         required: false
-        default: 17.x # Should be the same as the verison used for builds below.
+        default: 17.x
         type: string
       build-cmd:
         required: false
@@ -12,7 +12,6 @@ on:
       test-cmd:
         required: true
         type: string
-
 jobs:
   reusable_workflow_job:
     runs-on: ubuntu-latest
@@ -30,4 +29,3 @@ jobs:
           node-version: ${{ inputs.node-version-for-testing }}
       - run: npm ci --no-optional
       - run: ${{ test-cmd }}
-

From 40dea177a20ecf6d73bab76de8651977b1570684 Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 19:46:24 -0800
Subject: [PATCH 03/13] fixup! fixup! Split Build and Test steps in CI.

---
 .github/workflows/test.yml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index ae93d09f..9f0a96b1 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -19,10 +19,10 @@ jobs:
           test-cmd: npm run test_nobuild
   test_validstrings:
     steps:
-      uses: .github/workflows/test_base.yml
-      with:
-        node-version-for-testing: 17.x
-        test-cmd: npm run testValidStrings_nobuild
+      - uses: .github/workflows/test_base.yml
+        with:
+          node-version-for-testing: 17.x
+          test-cmd: npm run testValidStrings_nobuild
   test-test262:
     runs-on: ubuntu-latest
     steps:

From caba2c75d68f03ddfba04e4126525dc6572f354d Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 19:49:48 -0800
Subject: [PATCH 04/13] fixup! fixup! fixup! Split Build and Test steps in CI.

---
 .github/workflows/test.yml      | 6 ++++--
 .github/workflows/test_base.yml | 1 -
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 9f0a96b1..fcaef431 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -13,13 +13,15 @@ jobs:
           - 16.x
           - 14.x
     steps:
-      - uses: .github/workflows/test_base.yml
+      - uses: actions/checkout@v2
+      - uses: ./.github/workflows/test_base.yml
         with:
           node-version-for-testing: ${{ matrix.version }}
           test-cmd: npm run test_nobuild
   test_validstrings:
     steps:
-      - uses: .github/workflows/test_base.yml
+      - uses: actions/checkout@v2
+      - uses: ./.github/workflows/test_base.yml
         with:
           node-version-for-testing: 17.x
           test-cmd: npm run testValidStrings_nobuild
diff --git a/.github/workflows/test_base.yml b/.github/workflows/test_base.yml
index 8d51d6d3..53a3be84 100644
--- a/.github/workflows/test_base.yml
+++ b/.github/workflows/test_base.yml
@@ -16,7 +16,6 @@ jobs:
   reusable_workflow_job:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
       - name: use node.js v17.x for build
         uses: actions/setup-node@v1
         with:

From d52808e201f56ddceffd2bb29a1d72f5629603cf Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 19:51:45 -0800
Subject: [PATCH 05/13] fixup! fixup! fixup! fixup! Split Build and Test steps
 in CI.

---
 .github/workflows/test.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index fcaef431..094633db 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -6,6 +6,7 @@ on:
       - main
 jobs:
   test_demitasse_matrix:
+    runs-on: ubuntu-latest
     strategy:
       matrix:
         version:
@@ -19,6 +20,7 @@ jobs:
           node-version-for-testing: ${{ matrix.version }}
           test-cmd: npm run test_nobuild
   test_validstrings:
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: ./.github/workflows/test_base.yml

From 3a8bdf46f4a7f439c0ebf1ecd63440610c631864 Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 20:04:06 -0800
Subject: [PATCH 06/13] fixup! fixup! fixup! fixup! fixup! Split Build and Test
 steps in CI.

---
 .../{test_base.yml => build_and_test.yml}     |   0
 .github/workflows/test.yml                    | 121 +++++++++---------
 2 files changed, 59 insertions(+), 62 deletions(-)
 rename .github/workflows/{test_base.yml => build_and_test.yml} (100%)

diff --git a/.github/workflows/test_base.yml b/.github/workflows/build_and_test.yml
similarity index 100%
rename from .github/workflows/test_base.yml
rename to .github/workflows/build_and_test.yml
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 094633db..a3c8f0b3 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -6,7 +6,6 @@ on:
       - main
 jobs:
   test_demitasse_matrix:
-    runs-on: ubuntu-latest
     strategy:
       matrix:
         version:
@@ -15,72 +14,70 @@ jobs:
           - 14.x
     steps:
       - uses: actions/checkout@v2
-      - uses: ./.github/workflows/test_base.yml
+      - uses: ./.github/workflows/build_and_test.yml
         with:
           node-version-for-testing: ${{ matrix.version }}
           test-cmd: npm run test_nobuild
   test_validstrings:
-    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: ./.github/workflows/test_base.yml
+      - uses: ./.github/workflows/build_and_test.yml
         with:
-          node-version-for-testing: 17.x
           test-cmd: npm run testValidStrings_nobuild
-  test-test262:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          submodules: true
-      - name: use node.js v17.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 17.x
-      - run: npm ci
-      - run: npm run test262
-        env:
-          HEAD_SHA: ${{ github.event.pull_request.head.sha }}
-  test-test262-opt:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          submodules: true
-      - name: use node.js v17.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 17.x
-      - run: npm ci
-      - run: npm run test262
-        env:
-          HEAD_SHA: ${{ github.event.pull_request.head.sha }}
-          NODE_ENV: production
-  test-test262-es5:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          submodules: true
-      - name: use node.js v17.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 17.x
-      - run: npm ci
-      - run: npm run test262
-        env:
-          HEAD_SHA: ${{ github.event.pull_request.head.sha }}
-          NODE_ENV: production
-          TRANSPILE: "1"
-  test-validstrings:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - name: use node.js v16.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 16.x
-      - run: npm ci
-      - run: |
-          npm ci
-          npm run testValidStrings
+  # test-test262:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #       with:
+  #         submodules: true
+  #     - name: use node.js v17.x
+  #       uses: actions/setup-node@v1
+  #       with:
+  #         node-version: 17.x
+  #     - run: npm ci
+  #     - run: npm run test262
+  #       env:
+  #         HEAD_SHA: ${{ github.event.pull_request.head.sha }}
+  # test-test262-opt:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #       with:
+  #         submodules: true
+  #     - name: use node.js v17.x
+  #       uses: actions/setup-node@v1
+  #       with:
+  #         node-version: 17.x
+  #     - run: npm ci
+  #     - run: npm run test262
+  #       env:
+  #         HEAD_SHA: ${{ github.event.pull_request.head.sha }}
+  #         NODE_ENV: production
+  # test-test262-es5:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #       with:
+  #         submodules: true
+  #     - name: use node.js v17.x
+  #       uses: actions/setup-node@v1
+  #       with:
+  #         node-version: 17.x
+  #     - run: npm ci
+  #     - run: npm run test262
+  #       env:
+  #         HEAD_SHA: ${{ github.event.pull_request.head.sha }}
+  #         NODE_ENV: production
+  #         TRANSPILE: "1"
+  # test-validstrings:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #     - name: use node.js v16.x
+  #       uses: actions/setup-node@v1
+  #       with:
+  #         node-version: 16.x
+  #     - run: npm ci
+  #     - run: |
+  #         npm ci
+  #         npm run testValidStrings

From fc79b6b2909dbe7a25784a3d0621e9ee9c866f62 Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 20:09:45 -0800
Subject: [PATCH 07/13] fixup! fixup! fixup! fixup! fixup! fixup! Split Build
 and Test steps in CI.

---
 .github/workflows/build_and_test.yml | 1 +
 .github/workflows/test.yml           | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index 53a3be84..8d51d6d3 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -16,6 +16,7 @@ jobs:
   reusable_workflow_job:
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/checkout@v2
       - name: use node.js v17.x for build
         uses: actions/setup-node@v1
         with:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index a3c8f0b3..957ceb0b 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -13,14 +13,12 @@ jobs:
           - 16.x
           - 14.x
     steps:
-      - uses: actions/checkout@v2
       - uses: ./.github/workflows/build_and_test.yml
         with:
           node-version-for-testing: ${{ matrix.version }}
           test-cmd: npm run test_nobuild
   test_validstrings:
     steps:
-      - uses: actions/checkout@v2
       - uses: ./.github/workflows/build_and_test.yml
         with:
           test-cmd: npm run testValidStrings_nobuild

From 076dd38f4132878d0a943b5d006a70cda2c5b45f Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 20:11:19 -0800
Subject: [PATCH 08/13] fixup! fixup! fixup! fixup! fixup! fixup! fixup! Split
 Build and Test steps in CI.

---
 .github/workflows/test.yml | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 957ceb0b..46564ec9 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -12,16 +12,14 @@ jobs:
           - 17.x
           - 16.x
           - 14.x
-    steps:
-      - uses: ./.github/workflows/build_and_test.yml
-        with:
-          node-version-for-testing: ${{ matrix.version }}
-          test-cmd: npm run test_nobuild
+    uses: ./.github/workflows/build_and_test.yml
+      with:
+        node-version-for-testing: ${{ matrix.version }}
+        test-cmd: npm run test_nobuild
   test_validstrings:
-    steps:
-      - uses: ./.github/workflows/build_and_test.yml
-        with:
-          test-cmd: npm run testValidStrings_nobuild
+    uses: ./.github/workflows/build_and_test.yml
+      with:
+        test-cmd: npm run testValidStrings_nobuild
   # test-test262:
   #   runs-on: ubuntu-latest
   #   steps:

From 9074c0ac6ea48b2f117ccf022eb07a627e828638 Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 20:13:16 -0800
Subject: [PATCH 09/13] fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup!
 Split Build and Test steps in CI.

---
 .github/workflows/test.yml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 46564ec9..0a0a7363 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -13,13 +13,13 @@ jobs:
           - 16.x
           - 14.x
     uses: ./.github/workflows/build_and_test.yml
-      with:
-        node-version-for-testing: ${{ matrix.version }}
-        test-cmd: npm run test_nobuild
+    with:
+      node-version-for-testing: ${{ matrix.version }}
+      test-cmd: npm run test_nobuild
   test_validstrings:
     uses: ./.github/workflows/build_and_test.yml
-      with:
-        test-cmd: npm run testValidStrings_nobuild
+    with:
+      test-cmd: npm run testValidStrings_nobuild
   # test-test262:
   #   runs-on: ubuntu-latest
   #   steps:

From dda415f17bdbd5a1c6b912f6ad00f79f34b4b413 Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 20:14:53 -0800
Subject: [PATCH 10/13] fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup!
 fixup! Split Build and Test steps in CI.

---
 .github/workflows/build_and_test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index 8d51d6d3..08ee544a 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -28,4 +28,4 @@ jobs:
         with:
           node-version: ${{ inputs.node-version-for-testing }}
       - run: npm ci --no-optional
-      - run: ${{ test-cmd }}
+      - run: ${{ inputs.test-cmd }}

From 1fd96d2ad973b22a8f71bc1afa84da35cfa1914f Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 20:16:04 -0800
Subject: [PATCH 11/13] fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup!
 fixup! fixup! Split Build and Test steps in CI.

---
 .github/workflows/build_and_test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index 08ee544a..df9db9c3 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -20,7 +20,7 @@ jobs:
       - name: use node.js v17.x for build
         uses: actions/setup-node@v1
         with:
-          node-version: lts/*
+          node-version: lts
       - run: npm ci --no-optional
       - run: ${{ inputs.build-cmd }}
       - name: use node.js for test execution

From 38fab86dbb1db157cb09160c18271e2870c8e922 Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 20:21:26 -0800
Subject: [PATCH 12/13] fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup!
 fixup! fixup! fixup! Split Build and Test steps in CI.

---
 .github/workflows/build_and_test.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index df9db9c3..e8a3ace4 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -3,7 +3,7 @@ on:
     inputs:
       node-version-for-testing:
         required: false
-        default: 17.x
+        default: lts/hydrogen
         type: string
       build-cmd:
         required: false
@@ -20,7 +20,7 @@ jobs:
       - name: use node.js v17.x for build
         uses: actions/setup-node@v1
         with:
-          node-version: lts
+          node-version: lts/hydrogen
       - run: npm ci --no-optional
       - run: ${{ inputs.build-cmd }}
       - name: use node.js for test execution

From a9f93552f6d00c611ed385cfb5eb566212cc89a9 Mon Sep 17 00:00:00 2001
From: James Wright <jameswr@google.com>
Date: Wed, 7 Dec 2022 20:23:27 -0800
Subject: [PATCH 13/13] fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup!
 fixup! fixup! fixup! fixup! Split Build and Test steps in CI.

---
 .github/workflows/build_and_test.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index e8a3ace4..76d41f7d 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -3,7 +3,7 @@ on:
     inputs:
       node-version-for-testing:
         required: false
-        default: lts/hydrogen
+        default: 18.x
         type: string
       build-cmd:
         required: false
@@ -20,7 +20,7 @@ jobs:
       - name: use node.js v17.x for build
         uses: actions/setup-node@v1
         with:
-          node-version: lts/hydrogen
+          node-version: 18.x
       - run: npm ci --no-optional
       - run: ${{ inputs.build-cmd }}
       - name: use node.js for test execution