remove unnecessary code

Author: jaredcnance

src/JsonApiDotNetCore/Builders/ContextGraphBuilder.cs

@@ -191,20 +191,10 @@ protected virtual List<RelationshipAttribute> GetRelationships(Type entityType)
                     // Article → ArticleTag.Article
                     hasManyThroughAttribute.LeftProperty = throughProperties.SingleOrDefault(x => x.PropertyType == entityType)
                         ?? throw new JsonApiSetupException($"{hasManyThroughAttribute.ThroughType} does not contain a navigation property to type {entityType}");
-                  
-                    // ArticleTag.ArticleId
-                    var leftIdPropertyName = hasManyThroughAttribute.GetIdentityPropertyName(hasManyThroughAttribute.LeftProperty);
-                    hasManyThroughAttribute.LeftIdProperty = throughProperties.SingleOrDefault(p => p.Name == leftIdPropertyName)
-                        ?? throw new JsonApiSetupException($"{hasManyThroughAttribute.ThroughType} does not contain an identity property {leftIdPropertyName}");
 
                     // Article → ArticleTag.Tag
                     hasManyThroughAttribute.RightProperty = throughProperties.SingleOrDefault(x => x.PropertyType == hasManyThroughAttribute.Type)
                         ?? throw new JsonApiSetupException($"{hasManyThroughAttribute.ThroughType} does not contain a navigation property to type {hasManyThroughAttribute.Type}");
-                    
-                    // ArticleTag.TagId
-                    var rightIdPropertyName = hasManyThroughAttribute.GetIdentityPropertyName(hasManyThroughAttribute.RightProperty);
-                    hasManyThroughAttribute.RightIdProperty = throughProperties.SingleOrDefault(p => p.Name == rightIdPropertyName)
-                        ?? throw new JsonApiSetupException($"{hasManyThroughAttribute.ThroughType} does not contain an identity property {rightIdPropertyName}");
                 }
             }
 

src/JsonApiDotNetCore/Models/HasManyThroughAttribute.cs

@@ -95,21 +95,6 @@ public HasManyThroughAttribute(string publicName, string internalThroughName, Li
         /// </example>
         public PropertyInfo LeftProperty { get; internal set; }
 
-        /// <summary>
-        /// The identity property back to the parent resource.
-        /// </summary>
-        /// 
-        /// <example>
-        /// In the `[HasManyThrough("tags", nameof(ArticleTags))]` example
-        /// this would point to the `Article.ArticleTags.ArticleId` property
-        ///
-        /// <code>
-        /// public int ArticleId { get; set; }
-        /// </code>
-        ///
-        /// </example>
-        public PropertyInfo LeftIdProperty { get; internal set; }
-
         /// <summary>
         /// The navigation property to the related resource from the join type.
         /// </summary>
@@ -125,32 +110,6 @@ public HasManyThroughAttribute(string publicName, string internalThroughName, Li
         /// </example>
         public PropertyInfo RightProperty { get; internal set; }
 
-        /// <summary>
-        /// The identity property back to the related resource from the join type.
-        /// </summary>
-        /// 
-        /// <example>
-        /// In the `[HasManyThrough("tags", nameof(ArticleTags))]` example
-        /// this would point to the `Article.ArticleTags.TagId` property
-        ///
-        /// <code>
-        /// public int TagId { get; set; }
-        /// </code>
-        ///
-        /// </example>
-        public PropertyInfo RightIdProperty { get; internal set; }
-
-        /// <summary>
-        /// Get the name of the identity property from the navigation property.
-        /// </summary>
-        /// 
-        /// <example>
-        /// In the `[HasManyThrough("tags", nameof(ArticleTags))]` example
-        /// this would translate to the `Article.ArticleTags.Tag` property
-        /// to TagId. This is then used to set the Left and RightIdProperties.
-        /// </example>
-        public virtual string GetIdentityPropertyName(PropertyInfo property) => property.Name + "Id";
-
         /// <summary>
         /// The join entity property on the parent resource.
         /// </summary>