fix(DocumentBuilder): use the new GetRelationshipValue API

Author: jaredcnance

src/Examples/JsonApiDotNetCoreExample/Models/Tag.cs

@@ -4,7 +4,7 @@ namespace JsonApiDotNetCoreExample.Models
 {
     public class Tag : Identifiable
     {
-        [Attr("name")]
+        [Attr]
         public string Name { get; set; }
     }
 }

src/JsonApiDotNetCore/Builders/DocumentBuilder.cs

@@ -217,7 +217,7 @@ private List<ResourceObject> IncludeRelationshipChain(
             if(relationship == null)
                 throw new JsonApiException(400, $"{parentEntity.EntityName} does not contain relationship {requestedRelationship}");
 
-            var navigationEntity = _jsonApiContext.ContextGraph.GetRelationship(parentResource, relationship.InternalRelationshipName);
+            var navigationEntity = _jsonApiContext.ContextGraph.GetRelationshipValue(parentResource, relationship);
             if (navigationEntity is IEnumerable hasManyNavigationEntity)
             {
                 foreach (IIdentifiable includedEntity in hasManyNavigationEntity)

src/JsonApiDotNetCore/Data/DefaultEntityRepository.cs

@@ -321,9 +321,7 @@ public virtual IQueryable<TEntity> Include(IQueryable<TEntity> entities, string
                     entity = _jsonApiContext.ContextGraph.GetContextEntity(relationship.Type);
             }
 
-            IQueryable<TEntity> included = entities.Include(internalRelationshipPath);
-            AttachHasManyThrough(relationshipChain, included);
-            return included;
+            return entities.Include(internalRelationshipPath);
         }
 
         /// <inheritdoc />
@@ -370,29 +368,5 @@ public async Task<IReadOnlyList<TEntity>> ToListAsync(IQueryable<TEntity> entiti
                 ? await entities.ToListAsync()
                 : entities.ToList();
         }
-
-        private void AttachHasManyThrough(string[] relationshipChain, IQueryable<TEntity> included)
-        {
-            var hasManyThroughRelationships = _jsonApiContext.RequestEntity.Relationships.OfType<HasManyThroughAttribute>();
-            foreach (var hasManyThroughRelation in _jsonApiContext.RequestEntity.Relationships.OfType<HasManyThroughAttribute>())
-            {
-                if (relationshipChain.Contains(hasManyThroughRelation.PublicRelationshipName))
-                {
-                    Type rightInstancesListType = typeof(List<>).MakeGenericType(hasManyThroughRelation.Type);
-                    PropertyInfo rightPropertyOnLeft = _jsonApiContext.RequestEntity.EntityType.GetProperty(hasManyThroughRelation.InternalRelationshipName);
-                    foreach (var leftInstance in included)
-                    {
-                        var rightInstancesList = (IList)Activator.CreateInstance(rightInstancesListType);
-                        var throughInstances = (IList)hasManyThroughRelation.ThroughProperty.GetValue(leftInstance);
-                        foreach (var ti in throughInstances)
-                        {
-                            var rightInstance = hasManyThroughRelation.RightProperty.GetValue(ti);
-                            rightInstancesList.Add(rightInstance);
-                        }
-                        rightPropertyOnLeft.SetValue(leftInstance, rightInstancesList);
-                    }
-                }
-            }
-        }
     }
 }