Introduce Resource.from() and make DefaultResource package-private

Closes #4879

Author: sbrannen

documentation/src/docs/asciidoc/release-notes/release-notes-6.0.0.adoc

@@ -38,7 +38,8 @@ guidance on upgrading from JUnit 5.x.y to 6.0.0.
 [[release-notes-6.0.0-junit-platform-new-features-and-improvements]]
 ==== New Features and Improvements
 
-* ❓
+* New `Resource.from(String, URI)` static factory method for creating an
+  `org.junit.platform.commons.support.Resource`.
 
 
 [[release-notes-6.0.0-junit-jupiter]]

junit-platform-commons/src/main/java/org/junit/platform/commons/support/DefaultResource.java

@@ -10,25 +10,17 @@
 
 package org.junit.platform.commons.support;
 
-import static org.apiguardian.api.API.Status.INTERNAL;
-
 import java.net.URI;
 
-import org.apiguardian.api.API;
 import org.junit.platform.commons.util.Preconditions;
 import org.junit.platform.commons.util.ToStringBuilder;
 
 /**
- * <h2>DISCLAIMER</h2>
- *
- * <p>This class is intended solely for usage within the JUnit framework itself.
- * <strong>Any usage by external parties is not supported.</strong>
- * Use at your own risk!
+ * Default implementation of {@link Resource}.
  *
  * @since 1.11
  */
-@API(status = INTERNAL, since = "1.12")
-public record DefaultResource(String name, URI uri) implements Resource {
+record DefaultResource(String name, URI uri) implements Resource {
 
 	public DefaultResource {
 		Preconditions.notNull(name, "name must not be null");

junit-platform-commons/src/main/java/org/junit/platform/commons/support/Resource.java

@@ -38,6 +38,19 @@
 @API(status = MAINTAINED, since = "1.13.3")
 public interface Resource {
 
+	/**
+	 * Create a new {@link Resource} with the given name and URI.
+	 *
+	 * @param name the name of the resource; never {@code null}
+	 * @param uri the URI of the resource; never {@code null}
+	 * @return a new {@code Resource}
+	 * @since 6.0
+	 */
+	@API(status = MAINTAINED, since = "6.0")
+	static Resource from(String name, URI uri) {
+		return new DefaultResource(name, uri);
+	}
+
 	/**
 	 * Get the name of this resource.
 	 *

junit-platform-commons/src/main/java/org/junit/platform/commons/support/scanning/DefaultClasspathScanner.java

@@ -38,7 +38,6 @@
 import org.junit.platform.commons.function.Try;
 import org.junit.platform.commons.logging.Logger;
 import org.junit.platform.commons.logging.LoggerFactory;
-import org.junit.platform.commons.support.DefaultResource;
 import org.junit.platform.commons.support.Resource;
 import org.junit.platform.commons.util.PackageUtils;
 import org.junit.platform.commons.util.Preconditions;
@@ -215,7 +214,7 @@ private void processResourceFileSafely(Path baseDir, String basePackageName, Pre
 		try {
 			String fullyQualifiedResourceName = determineFullyQualifiedResourceName(baseDir, basePackageName,
 				resourceFile);
-			Resource resource = new DefaultResource(fullyQualifiedResourceName, resourceFile.toUri());
+			Resource resource = Resource.from(fullyQualifiedResourceName, resourceFile.toUri());
 			if (resourceFilter.test(resource)) {
 				resourceConsumer.accept(resource);
 			}

junit-platform-commons/src/main/java/org/junit/platform/commons/util/ModuleUtils.java

@@ -36,7 +36,6 @@
 import org.junit.platform.commons.JUnitException;
 import org.junit.platform.commons.logging.Logger;
 import org.junit.platform.commons.logging.LoggerFactory;
-import org.junit.platform.commons.support.DefaultResource;
 import org.junit.platform.commons.support.Resource;
 import org.junit.platform.commons.support.scanning.ClassFilter;
 
@@ -289,7 +288,7 @@ List<Resource> scan(ModuleReference reference) {
 		private Resource loadResourceUnchecked(String binaryName) {
 			try {
 				URI uri = requireNonNull(classLoader.getResource(binaryName)).toURI();
-				return new DefaultResource(binaryName, uri);
+				return Resource.from(binaryName, uri);
 			}
 			catch (NullPointerException | URISyntaxException e) {
 				throw new JUnitException("Failed to load resource with name '" + binaryName + "'.", e);

junit-platform-commons/src/main/java/org/junit/platform/commons/util/ReflectionUtils.java

@@ -60,7 +60,6 @@
 import org.junit.platform.commons.function.Try;
 import org.junit.platform.commons.logging.Logger;
 import org.junit.platform.commons.logging.LoggerFactory;
-import org.junit.platform.commons.support.DefaultResource;
 import org.junit.platform.commons.support.Resource;
 import org.junit.platform.commons.support.scanning.ClassFilter;
 import org.junit.platform.commons.support.scanning.ClasspathScanner;
@@ -795,7 +794,7 @@ public static Try<Set<Resource>> tryToGetResources(String classpathResourceName,
 			List<URL> resources = Collections.list(classLoader.getResources(canonicalClasspathResourceName));
 			return resources.stream().map(url -> {
 				try {
-					return new DefaultResource(canonicalClasspathResourceName, url.toURI());
+					return Resource.from(canonicalClasspathResourceName, url.toURI());
 				}
 				catch (URISyntaxException e) {
 					throw ExceptionUtils.throwAsUncheckedException(e);