From 88d2670ee87bd9ee0414dfb045b655ba8e905aa4 Mon Sep 17 00:00:00 2001 From: David Dal Busco Date: Fri, 20 Jun 2025 06:28:44 +0200 Subject: [PATCH 1/7] fix: error manifest path does not exist when unused --- src/services/functions/build/build.services.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/services/functions/build/build.services.ts b/src/services/functions/build/build.services.ts index fdad173a..7fda3bd5 100644 --- a/src/services/functions/build/build.services.ts +++ b/src/services/functions/build/build.services.ts @@ -116,6 +116,8 @@ const executeSputnikBuild = async ({ const withToolchain = nonNullish(paths?.cargo) || ENV.ci; + console.log(withToolchain, paths?.cargo, ENV.ci) + if (withToolchain) { const rustPaths = { ...paths, From 591d51ba3f6b44175188a7ea980bf52615aebd6c Mon Sep 17 00:00:00 2001 From: David Dal Busco Date: Fri, 20 Jun 2025 06:34:16 +0200 Subject: [PATCH 2/7] chore: debug --- src/cli/env.loader.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cli/env.loader.ts b/src/cli/env.loader.ts index 758ad8fa..4c73c3d5 100644 --- a/src/cli/env.loader.ts +++ b/src/cli/env.loader.ts @@ -13,6 +13,8 @@ export const loadEnv = (): JunoCliEnv => { const ci = process.env.CI === 'true'; + console.log(ci, process.env); + return { mode: mode ?? 'production', containerUrl: envContainerUrl, From 5ebd9c0e07691b39bc3b374134f29a9351609c3b Mon Sep 17 00:00:00 2001 From: David Dal Busco Date: Fri, 20 Jun 2025 06:39:33 +0200 Subject: [PATCH 3/7] chore: debug --- src/cli/env.loader.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cli/env.loader.ts b/src/cli/env.loader.ts index 4c73c3d5..15031159 100644 --- a/src/cli/env.loader.ts +++ b/src/cli/env.loader.ts @@ -13,6 +13,7 @@ export const loadEnv = (): JunoCliEnv => { const ci = process.env.CI === 'true'; + console.log('CI =', process.env.CI); console.log(ci, process.env); return { From 84301060688bf4a3d844695f3438f8153ee23414 Mon Sep 17 00:00:00 2001 From: David Dal Busco Date: Fri, 20 Jun 2025 06:47:28 +0200 Subject: [PATCH 4/7] chore: debug --- src/cli/env.loader.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/cli/env.loader.ts b/src/cli/env.loader.ts index 15031159..c649759c 100644 --- a/src/cli/env.loader.ts +++ b/src/cli/env.loader.ts @@ -13,8 +13,11 @@ export const loadEnv = (): JunoCliEnv => { const ci = process.env.CI === 'true'; - console.log('CI =', process.env.CI); - console.log(ci, process.env); + console.log('CI =', process.env.CI, "CI" in process.env); + console.log('CI in process.env:', 'CI' in process.env); + console.log('process.env.CI:', process.env.CI); + console.log('Own keys:', Object.keys(process.env)); + console.log('CI descriptor:', Object.getOwnPropertyDescriptor(process.env, 'CI')); return { mode: mode ?? 'production', From 2b9a1acccd81dcd87aa97f08d219b23127ac3c97 Mon Sep 17 00:00:00 2001 From: David Dal Busco Date: Fri, 20 Jun 2025 07:02:50 +0200 Subject: [PATCH 5/7] fix: do not injet env at build time --- scripts/esbuild.mjs | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/scripts/esbuild.mjs b/scripts/esbuild.mjs index a6bee9a6..dee69f57 100644 --- a/scripts/esbuild.mjs +++ b/scripts/esbuild.mjs @@ -21,14 +21,6 @@ export const externalDependencies = [ ...Object.keys(devDependencies) ]; -const define = Object.entries(process.env).reduce( - (acc, [key, value]) => ({ - ...acc, - [`process.env.${key}`]: JSON.stringify(value) - }), - {} -); - const dist = join(process.cwd(), 'dist'); if (!existsSync(dist)) { @@ -46,8 +38,7 @@ const script = await esbuild.build({ banner: { js: "import { createRequire as topLevelCreateRequire } from 'module';\n const require = topLevelCreateRequire(import.meta.url);" }, - external: externalDependencies, - define + external: externalDependencies }); writeFileSync('dist/index.js', `#!/usr/bin/env node\n${script.outputFiles[0].text}`); From 85a2d97396724f96cfc22199b1e9cc97562bb34a Mon Sep 17 00:00:00 2001 From: David Dal Busco Date: Fri, 20 Jun 2025 07:05:50 +0200 Subject: [PATCH 6/7] chore: revert debug --- src/cli/env.loader.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/cli/env.loader.ts b/src/cli/env.loader.ts index c649759c..758ad8fa 100644 --- a/src/cli/env.loader.ts +++ b/src/cli/env.loader.ts @@ -13,12 +13,6 @@ export const loadEnv = (): JunoCliEnv => { const ci = process.env.CI === 'true'; - console.log('CI =', process.env.CI, "CI" in process.env); - console.log('CI in process.env:', 'CI' in process.env); - console.log('process.env.CI:', process.env.CI); - console.log('Own keys:', Object.keys(process.env)); - console.log('CI descriptor:', Object.getOwnPropertyDescriptor(process.env, 'CI')); - return { mode: mode ?? 'production', containerUrl: envContainerUrl, From 0427f38d1a6c2c871e41482855309883bdac6587 Mon Sep 17 00:00:00 2001 From: David Dal Busco Date: Fri, 20 Jun 2025 07:06:14 +0200 Subject: [PATCH 7/7] chore: revert debug --- src/services/functions/build/build.services.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/services/functions/build/build.services.ts b/src/services/functions/build/build.services.ts index 7fda3bd5..fdad173a 100644 --- a/src/services/functions/build/build.services.ts +++ b/src/services/functions/build/build.services.ts @@ -116,8 +116,6 @@ const executeSputnikBuild = async ({ const withToolchain = nonNullish(paths?.cargo) || ENV.ci; - console.log(withToolchain, paths?.cargo, ENV.ci) - if (withToolchain) { const rustPaths = { ...paths,