From 0255d3de0942d4f85825bdb9492d965d6d73ae56 Mon Sep 17 00:00:00 2001 From: David Dal Busco Date: Sat, 27 Sep 2025 10:13:16 +0200 Subject: [PATCH 1/3] feat(config): extend emulator type with apple container --- packages/config/README.md | 4 ++-- .../config/src/satellite/configs/emulator.config.ts | 4 ++-- .../tests/satellite/configs/emulator.config.spec.ts | 10 ++++++++++ 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/packages/config/README.md b/packages/config/README.md index a9b0fcfcd..621e97d8f 100644 --- a/packages/config/README.md +++ b/packages/config/README.md @@ -207,7 +207,7 @@ References: | Constant | Type | | ---------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `EmulatorConfigSchema` | `ZodUnion; image: ZodOptional; name: ZodOptional; volume: ZodOptional<...>; target: ZodOptional<...>; platform: ZodOptional<...>; }, $strict>>; skylab: ZodObject<...>; }, $strict>, ZodObj...` | +| `EmulatorConfigSchema` | `ZodUnion; image: ZodOptional; name: ZodOptional; volume: ZodOptional<...>; target: ZodOptional<...>; platform: ZodOptional<...>; }, $strict>>; skylab: ZodObject<....` | References: @@ -604,7 +604,7 @@ Shared options for all runner variants. | Property | Type | Description | | ---------- | --------------------------------------------- | ----------------------------------------------------------------------------------------------------- | -| `type` | `"docker" or "podman"` | The containerization tool to run the emulator. | +| `type` | `"docker" or "podman" or "container"` | The containerization tool to run the emulator. | | `image` | `string or undefined` | Image reference. default: depends on emulator type, e.g. "junobuild/skylab:latest" | | `name` | `string or undefined` | Optional container name to use for the emulator. Useful for reusing or managing a specific container. | | `volume` | `string or undefined` | Persistent volume to store internal state. default: "juno" | diff --git a/packages/config/src/satellite/configs/emulator.config.ts b/packages/config/src/satellite/configs/emulator.config.ts index 3c24b7961..ec5b1cd0c 100644 --- a/packages/config/src/satellite/configs/emulator.config.ts +++ b/packages/config/src/satellite/configs/emulator.config.ts @@ -99,7 +99,7 @@ export interface EmulatorSatellite { * @see EmulatorRunner */ const EmulatorRunnerSchema = z.strictObject({ - type: z.enum(['docker', 'podman']), + type: z.enum(['docker', 'podman', 'container']), image: z.string().optional(), name: z.string().optional(), volume: z.string().optional(), @@ -114,7 +114,7 @@ export interface EmulatorRunner { /** * The containerization tool to run the emulator. */ - type: 'docker' | 'podman'; + type: 'docker' | 'podman' | 'container'; /** * Image reference. diff --git a/packages/config/src/tests/satellite/configs/emulator.config.spec.ts b/packages/config/src/tests/satellite/configs/emulator.config.spec.ts index 1431edcee..0a61e2f8c 100644 --- a/packages/config/src/tests/satellite/configs/emulator.config.spec.ts +++ b/packages/config/src/tests/satellite/configs/emulator.config.spec.ts @@ -219,6 +219,16 @@ describe('emulator.config', () => { expect(result.success).toBe(true); }); + it('accepts runner with type container', () => { + const result = EmulatorConfigSchema.safeParse({ + runner: { + type: 'container' + }, + console: {} + }); + expect(result.success).toBe(true); + }); + it('rejects runner with invalid type value', () => { const result = EmulatorConfigSchema.safeParse({ runner: { From 21a753bb82d90fe91544b12b50921652627bc20a Mon Sep 17 00:00:00 2001 From: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Date: Sat, 27 Sep 2025 09:10:57 +0000 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=A4=96=20Documentation=20auto-update?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/config/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/config/README.md b/packages/config/README.md index 4a4e398a2..cda3fe545 100644 --- a/packages/config/README.md +++ b/packages/config/README.md @@ -207,7 +207,7 @@ References: | Constant | Type | | ---------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `EmulatorConfigSchema` | `ZodUnion; image: ZodOptional; name: ZodOptional; volume: ZodOptional<...>; target: ZodOptional<...>; platform: ZodOptional<...>; }, $strict>>; network: ZodOptional<...>; skylab: ZodObjec...` | +| `EmulatorConfigSchema` | `ZodUnion; image: ZodOptional; name: ZodOptional; volume: ZodOptional<...>; target: ZodOptional<...>; platform: ZodOptional<...>; }, $strict>>; network: ZodOptiona...` | References: @@ -606,7 +606,7 @@ Shared options for all runner variants. | Property | Type | Description | | ---------- | --------------------------------------------- | ----------------------------------------------------------------------------------------------------- | -| `type` | `"docker" or "podman"` | The containerization tool to run the emulator. | +| `type` | `"docker" or "podman" or "container"` | The containerization tool to run the emulator. | | `image` | `string or undefined` | Image reference. default: depends on emulator type, e.g. "junobuild/skylab:latest" | | `name` | `string or undefined` | Optional container name to use for the emulator. Useful for reusing or managing a specific container. | | `volume` | `string or undefined` | Persistent volume to store internal state. default: "juno" | From e35fe02756a40895feddb418384e9079f973ab91 Mon Sep 17 00:00:00 2001 From: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 20 Apr 2026 08:00:08 +0000 Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=A4=96=20Documentation=20auto-update?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/config/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/config/README.md b/packages/config/README.md index dcaf2881d..572fa42d5 100644 --- a/packages/config/README.md +++ b/packages/config/README.md @@ -167,7 +167,7 @@ References: | Constant | Type | | ---------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `EmulatorConfigSchema` | `ZodUnion; image: ZodOptional; name: ZodOptional; volume: ZodOptional<...>; target: ZodOptional<...>; platform: ZodOptional<...>; extraHosts: ZodOptional<...>; }, $strict>>; network: ZodO...` | +| `EmulatorConfigSchema` | `ZodUnion; image: ZodOptional; name: ZodOptional; volume: ZodOptional<...>; target: ZodOptional<...>; platform: ZodOptional<...>; extraHosts: ZodOptional<...>; }, ...` | References: @@ -518,7 +518,7 @@ Shared options for all runner variants. | Property | Type | Description | | ------------ | --------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `type` | `"docker" or "podman"` | The containerization tool to run the emulator. | +| `type` | `"docker" or "podman" or "container"` | The containerization tool to run the emulator. | | `image` | `string or undefined` | Image reference. default: depends on emulator type, e.g. "junobuild/skylab:latest" | | `name` | `string or undefined` | Optional container name to use for the emulator. Useful for reusing or managing a specific container. | | `volume` | `string or undefined` | Persistent volume to store internal state. default: "juno" |