Skip to content

In consistent control/physics frequency desciption in tasks.py and maze.py #35

@yli2565

Description

@yli2565

In tasks.py

# Slow control (4Hz), so that agent without HRL has a chance.
# Native control would be ~20Hz, so this corresponds roughly to action_repeat=5.
DEFAULT_CONTROL_FREQ = 4.0

...

   task = MemoryMazeTask(
        ...
        control_timestep=1.0 / control_freq,
        ...
    )

So the control_timstep parameter is default to 0.25, which is 4Hz as intended

However, in maze.py

DEFAULT_CONTROL_TIMESTEP = 0.025
DEFAULT_PHYSICS_TIMESTEP = 0.005
...
class MemoryMazeTask(random_goal_maze.NullGoalMaze):
    # Adapted from dm_control.locomotion.tasks.RepeatSingleGoalMaze

    def __init__(self,
                 ...
                 physics_timestep=DEFAULT_PHYSICS_TIMESTEP,
                 control_timestep=DEFAULT_CONTROL_TIMESTEP,
                 ):
        super().__init__(
            ...
            physics_timestep=physics_timestep,
            control_timestep=control_timestep
        )

It seems the physics_timestep is default to 200Hz instead of 20Hz, and control frequency is deafult to 40Hz instead of 4Hz

Is that intended?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions