Skip to content

ModuleVersionInfo spec does not match actual output #100

@MrCreosote

Description

@MrCreosote

Spec:

   typedef structure {
        string module_name;
        string module_description;
        string git_url;
        boolean released;
        list<string> release_tags;
        int timestamp;
        string registration_id;
        string version;
        string git_commit_hash;
        string git_commit_message;
        boolean dynamic_service;
        list<string> narrative_app_ids;
        list<string> local_function_ids;
        string docker_img_name;
        string data_folder;
        string data_version;
        CompilationReport compilation_report;
    } ModuleVersion;

funcdef get_module_version(SelectModuleVersion selection) returns (ModuleVersion version);

Output:

curl -d '{"method": "Catalog.get_module_version", "params": [{"module_name": "DataFileUtil"}], "version": "1.1", "id": 1}' https://ci.kbase.us/services/catalog/ | python -mjson.tool
{
    "id": 1,
    "result": [
        {
            "docker_img_name": "dockerhub-ci.kbase.us/kbase:datafileutil.bcef6723524598b739e910f7d6ce9220d4b09bd2",
            "dynamic_service": 0,
            "git_commit_hash": "bcef6723524598b739e910f7d6ce9220d4b09bd2",
            "git_commit_message": "Merge pull request #58 from JamesJeffryes/SCT-1495\n\nSct-1495",
            "git_url": "https://github.com/kbaseapps/DataFileUtil",
            "local_functions": [
                "own_shock_node",
                "ws_name_to_id",
                "save_objects",
                "file_to_shock",
                "shock_to_file",
                "package_for_download",
                "unpack_file",
                "get_objects"
            ],
            "module_name": "DataFileUtil",
            "narrative_methods": [],
            "notes": "",
            "registration_id": "1538513104120_61d21109-2d18-40be-870a-d6d870d66042",
            "release_tags": [
                "release",
                "beta",
                "dev"
            ],
            "release_timestamp": 1538513276213,
            "released": 1,
            "released_timestamp": null,
            "timestamp": 1538513104120,
            "version": "0.0.25"
        }
    ],
    "version": "1.1"
}

I haven't checked every key, but the problems I ran into were:

        list<string> narrative_app_ids;
        list<string> local_function_ids;

vs.

            "local_functions": [
                "own_shock_node",
*snip*
                "get_objects"
            ],
            "narrative_methods": [],

This means the java clients are compiled incorrectly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions