-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
What would you like to be added?
The current values.yaml uses a flat naming convention for spawner and token-refresher resource configuration:
spawnerResourceRequests: ""
spawnerResourceLimits: ""
tokenRefresherResourceRequests: ""
tokenRefresherResourceLimits: ""In PR #783, controller resources were added using a more idiomatic nested Helm structure:
controller:
resources:
requests: ""
limits: ""The spawner and token-refresher values should be migrated to the same nested pattern for consistency:
spawner:
resources:
requests: ""
limits: ""
tokenRefresher:
resources:
requests: ""
limits: ""This would also allow future configuration for each component to be naturally grouped under its key (e.g., spawner.image, tokenRefresher.image).
Why is this needed?
- Consistency: the controller already uses the nested pattern
- Follows standard Helm conventions (e.g., similar to how upstream charts structure
resources) - Better extensibility for future per-component configuration
Per reviewer discussion in #783 (comment).
Reactions are currently unavailable