Merge pull request #5 from kenjis/fix-setMethods

Use onlyMethods() instead of setMethods()

Author: kenjis

composer.lock

@@ -19,7 +19,6 @@
     <file>src</file>
     <file>tests</file>
     <exclude-pattern>*/tmp/*</exclude-pattern>
-    <exclude-pattern>*/Fake/*</exclude-pattern>
 
     <!-- PSR12 Coding Standard -->
     <rule ref="PSR12"/>

phpcs.xml

@@ -21,7 +21,7 @@ trait TestDouble
      *
      * $email = $this->getMockBuilder('CI_Email')
      *    ->disableOriginalConstructor()
-     *    ->setMethods(['send'])
+     *    ->onlyMethods(['send'])
      *    ->getMock();
      * $email->method('send')->willReturn(true);
      *
@@ -67,7 +67,7 @@ public function getDouble(
             }
         }
 
-        $mock = $mockBuilder->setMethods($methods)->getMock();
+        $mock = $mockBuilder->onlyMethods($methods)->getMock();
 
         foreach ($onConsecutiveCalls as $method => $returns) {
             $mock->expects($this->any())->method($method)

src/TestDouble.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Kenjis\PhpUnitHelper;
+
+class Email
+{
+    public function to(string $to): Email
+    {
+        return $this;
+    }
+}

tests/Fake/CI_Email.php

@@ -6,14 +6,10 @@
 
 class ForReflectionHelper
 {
-    /**
-     * @var string
-     */
+    /** @var string */
     private $private = 'secret';
 
-    /**
-     * @var string
-     */
+    /** @var string */
     private static $staticPrivate = 'xyz';
 
     public function getPrivate(): string
@@ -31,7 +27,7 @@ private function privateMethod(string $param1, string $param2): string
         return 'private ' . $param1 . $param2;
     }
 
-    private static function privateStaticMethod(string $param1, string$param2): string
+    private static function privateStaticMethod(string $param1, string $param2): string
     {
         return 'private_static ' . $param1 . $param2;
     }

tests/Fake/CI_Input.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Kenjis\PhpUnitHelper;
+
+class Input
+{
+    public function method(bool $upper = false): string
+    {
+        return 'GET';
+    }
+
+    /**
+     * @param mixed $index
+     *
+     * @return mixed
+     */
+    public function get($index = null, bool $xssClean = false)
+    {
+        return 'GET value';
+    }
+}

tests/Fake/Email.php

@@ -14,7 +14,7 @@ class TestDoubleTest extends TestCase
     public function test_getDouble_method_named_method(): void
     {
         $expected = 'DELETE';
-        $mock = $this->getDouble(CI_Input::class, ['method' => $expected]);
+        $mock = $this->getDouble(Input::class, ['method' => $expected]);
 
         $actual = $mock->method();
 
@@ -25,7 +25,7 @@ public function test_getDouble_method_returns_consecutive(): void
     {
         $returns = ['GET', 'PUT', 'DELETE'];
         $mock = $this->getDouble(
-            CI_Input::class,
+            Input::class,
             [
                 ['method' => $returns],
             ]
@@ -45,7 +45,7 @@ public function test_getDouble_returns_consecutive_and_other(): void
     {
         $returns = ['GET', 'PUT', 'DELETE'];
         $mock = $this->getDouble(
-            CI_Input::class,
+            Input::class,
             [
                 'get' => [],
                 ['method' => $returns],
@@ -71,14 +71,19 @@ public function test_getDouble_returns_consecutive_and_other(): void
     public function test_getDouble_method_returns_execption(): void
     {
         $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('I can throw an exception and can use params: abcdef');
+        $this->expectExceptionMessage(
+            'I can throw an exception and can use params: abc1'
+        );
 
         $ret = static function ($param1, $param2): void {
-            throw new RuntimeException('I can throw an exception and can use params: ' . $param1 . $param2);
+            throw new RuntimeException(
+                'I can throw an exception and can use params: '
+                . $param1 . $param2
+            );
         };
-        $mock = $this->getDouble(CI_Input::class, ['method' => $ret]);
+        $mock = $this->getDouble(Input::class, ['get' => $ret]);
 
-        $mock->method('abc', 'def');
+        $mock->get('abc', true);
     }
 
     public function test_getDouble_constructor_param(): void
@@ -97,7 +102,7 @@ public function test_getDouble_constructor_param(): void
 
     public function test_getDobule_method_returns_phpunit_stub(): void
     {
-        $mock = $this->getDouble(CI_Email::class, ['to' => $this->returnSelf()]);
+        $mock = $this->getDouble(Email::class, ['to' => $this->returnSelf()]);
         $test = $mock->to('test@example.com');
 
         $this->assertEquals($mock, $test);
@@ -106,7 +111,7 @@ public function test_getDobule_method_returns_phpunit_stub(): void
     public function test_verifyInvokedOnce_with_params(): void
     {
         $expected = 'DELETE';
-        $mock = $this->getDouble(CI_Input::class, ['method' => $expected]);
+        $mock = $this->getDouble(Input::class, ['method' => $expected]);
 
         $this->verifyInvokedOnce($mock, 'method', [true]);
 
@@ -116,7 +121,7 @@ public function test_verifyInvokedOnce_with_params(): void
     public function test_verifyInvokedOnce_without_params(): void
     {
         $expected = 'DELETE';
-        $mock = $this->getDouble(CI_Input::class, ['method' => $expected]);
+        $mock = $this->getDouble(Input::class, ['method' => $expected]);
 
         $this->verifyInvokedOnce($mock, 'method');
 
@@ -126,7 +131,7 @@ public function test_verifyInvokedOnce_without_params(): void
     public function test_verifyInvoked_once(): void
     {
         $expected = 'DELETE';
-        $mock = $this->getDouble(CI_Input::class, ['method' => $expected]);
+        $mock = $this->getDouble(Input::class, ['method' => $expected]);
 
         $this->verifyInvoked($mock, 'method');
 
@@ -136,7 +141,7 @@ public function test_verifyInvoked_once(): void
     public function test_verifyInvoked_twice(): void
     {
         $expected = 'DELETE';
-        $mock = $this->getDouble(CI_Input::class, ['method' => $expected]);
+        $mock = $this->getDouble(Input::class, ['method' => $expected]);
 
         $this->verifyInvoked($mock, 'method');
 
@@ -147,7 +152,7 @@ public function test_verifyInvoked_twice(): void
     public function test_verifyInvokedMultipleTimes(): void
     {
         $expected = 'DELETE';
-        $mock = $this->getDouble(CI_Input::class, ['method' => $expected]);
+        $mock = $this->getDouble(Input::class, ['method' => $expected]);
 
         $this->verifyInvokedMultipleTimes($mock, 'method', 3);
 
@@ -159,7 +164,7 @@ public function test_verifyInvokedMultipleTimes(): void
     public function test_verifyNeverInvoked(): void
     {
         $expected = 'DELETE';
-        $mock = $this->getDouble(CI_Input::class, ['method' => $expected]);
+        $mock = $this->getDouble(Input::class, ['method' => $expected]);
 
         $this->verifyNeverInvoked($mock, 'method');
     }