Doens't compile for esp8266

[marcfon]

Was hoping to test this out today on a NodeMCU v1.0 but unfortunately it throws an error during compile time.
/Arduino/libraries/NeoPixelMeter/NeoPixelMeter.cpp:8:0: warning: "pgm_read_byte" redefined [enabled by default] #define pgm_read_byte(addr) (*(const unsigned char *)(addr)) ^ In file included from Library/Arduino15/packages/esp8266/hardware/esp8266/1.6.5-947-g39819f0/cores/esp8266/Arduino.h:230:0, from /Arduino/libraries/Adafruit_NeoPixel/Adafruit_NeoPixel.h:23, from /Arduino/libraries/NeoPixelMeter/NeoPixelMeter.cpp:2: Library/Arduino15/packages/esp8266/hardware/esp8266/1.6.5-947-g39819f0/cores/esp8266/pgmspace.h:77:0: note: this is the location of the previous definition #define pgm_read_byte(addr) \ ^ In file included from /Arduino/libraries/NeoPixelMeter/NeoPixelMeter.cpp:4:0: /Arduino/libraries/NeoPixelMeter/animation.h:13:38: warning: narrowing conversion of '164' from 'int' to 'const int8_t {aka const signed char}' inside { } [-Wnarrowing] 0, 28, 96, 164, 192, 164, 96, 28 }; ^ /Arduino/libraries/NeoPixelMeter/animation.h:13:38: warning: narrowing conversion of '192' from 'int' to 'const int8_t {aka const signed char}' inside { } [-Wnarrowing] /Arduino/libraries/NeoPixelMeter/animation.h:13:38: warning: narrowing conversion of '164' from 'int' to 'const int8_t {aka const signed char}' inside { } [-Wnarrowing] /Arduino/libraries/NeoPixelMeter/NeoPixelMeter.cpp: In member function 'void NeoPixelMeter::displayDraw()': /Arduino/libraries/NeoPixelMeter/NeoPixelMeter.cpp:127:19: warning: large integer implicitly truncated to unsigned type [-Woverflow] b = 2040;

And eventually it exist the compile chain with this error:

/Library/Arduino15/packages/esp8266/tools/xtensa-lx106-elf-gcc/1.20.0-26-gb404fb9/bin/../lib/gcc/xtensa-lx106-elf/4.8.2/../../../../xtensa-lx106-elf/lib/libm.a(lib_a-e_fmod.o):(.literal+0x0): undefined reference to__ieee754_remainder'
/Library/Arduino15/packages/esp8266/tools/xtensa-lx106-elf-gcc/1.20.0-26-gb404fb9/bin/../lib/gcc/xtensa-lx106-elf/4.8.2/../../../../xtensa-lx106-elf/lib/libm.a(lib_a-e_fmod.o): In function __ieee754_fmod': e_fmod.c:(.text+0x48): undefined reference to__ieee754_remainder'
collect2: error: ld returned 1 exit status
Error compiling.`

[kerber]

Unfortunately, this library was only ever tested against official Arduino boards.

That said, it doesn't look like any of the mentioned warnings coming out of the library were enough to trip it up. The message that did eventually kill the build aren't ones that are familiar to me. I don't think I'll be able to be of much help.

[marcfon]

Thanks, no problem. You are right that the error is coming from one of the esp8266 libraries. I'll see if I can debug this.

[marcfon]

The problem is somehow cause by the fmod() function in NeoPixelMeter.cpp, not sure why. I've replaced fmod(H,120); with H = ((int)(H * 100) % 120000)/100.0; which should do the same but I haven't tested it yet... There was one more thing that had to be changed: The whole #ifdef __AVR__ had to be commented. With these 2 things everything compiles!

One more question: In NeoPixelMeter.cpp:129 b is set to 2040. That seems like an oddly large value... is that correct or is it a typo?

[kerber]

I'm glad that you're making progress!

The value at NeoPixelMeter.cpp:129 is definitely a typo. I've updated the file, but it should be 240.

[marcfon]

The issue with fmod() seems to be an overall problem with the math lib that is shipped with the esp8266... it's described here http://bbs.espressif.com/viewtopic.php?t=944 For now I'll just have to test if my workaround works.

[marksev1]

Did the workaround, work marcfon? Did you guys get any further with this, would really like to use this library with my esp8266s?