Commit 9a82fde
authored
fix: size diff job (#413)
## 📜 Description
Fixed "0 bytes" diff from size-diff job report.
## 💡 Motivation and Context
It was incorrect metric. Such metric is totally useless.
The original problem was the fact that in new node `18.20.1` prints
output gathered from `react-native-builder-bob`:
```bash
> react-native-keyboard-controller@1.11.6 prepare
> bob build
ℹ Building target commonjs
ℹ Cleaning up previous build at lib/commonjs
ℹ Compiling 32 files in src with babel
✔ Wrote files to lib/commonjs
ℹ Building target module
ℹ Cleaning up previous build at lib/module
ℹ Compiling 32 files in src with babel
✔ Wrote files to lib/module
ℹ Building target typescript
ℹ Cleaning up previous build at lib/typescript
ℹ Generating type definitions with tsc
```
And such output can not be parsed.
The interesting thing is that `18.19.0` version produced expected
result. So in this PR I locked node version for this particular job.
## 📢 Changelog
<!-- High level overview of important changes -->
<!-- For example: fixed status bar manipulation; added new types
declarations; -->
<!-- If your changes don't affect one of platform/language below - then
remove this platform/language -->
### CI
- lock node to `18.19.0` for `size-diff` job;
## 🤔 How Has This Been Tested?
Tested on CI.
## 📸 Screenshots (if appropriate):
<img width="913" alt="image"
src="https://github.com/kirillzyusko/react-native-keyboard-controller/assets/22820318/e2dc190d-9d27-4e8e-b3df-cb60a954a9b4">
## 📝 Checklist
- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changed1 parent 7678eec commit 9a82fde
1 file changed
+6
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
21 | 25 | | |
22 | 26 | | |
23 | 27 | | |
| |||
26 | 30 | | |
27 | 31 | | |
28 | 32 | | |
| 33 | + | |
| 34 | + | |
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
| |||
0 commit comments