-
Notifications
You must be signed in to change notification settings - Fork 0
PR for v0.0.24 #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
PR for v0.0.24 #187
Conversation
…-lockfile Update dependency puppeteer to v24.3.0
Update dependency @stencil/core to v4.27.0
…er-data-view-web-component-0.x-lockfile Update dependency @kit-data-manager/data-view-web-component to v0.0.23
…file Update dependency @types/node to v22.13.5
|
Warning Rate limit exceeded@ThomasJejkal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 35 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
WalkthroughThe pull request updates multiple dependency versions in Changes
Poem
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…lockfile Update dependency storybook to v8.6.0
Update dependency @stencil/core to v4.27.1
…components-vite-8.x-lockfile Update dependency @storybook/web-components-vite to v8.6.0
…components-8.x-lockfile Update dependency @storybook/web-components to v8.6.1
…prettier-10.x-lockfile Update dependency eslint-config-prettier to v10.0.2
…lockfile Update dependency storybook to v8.6.2
…components-8.x-lockfile Update dependency @storybook/web-components to v8.6.2
…components-vite-8.x-lockfile Update dependency @storybook/web-components-vite to v8.6.2
…ks-8.x-lockfile Update dependency @storybook/blocks to v8.6.2
…output-target-1.x-lockfile Update dependency @stencil/react-output-target to v1.1.1
Update dependency @stencil/core to v4.35.1
…n-docs-9.x-lockfile Update dependency @storybook/addon-docs to v9.0.14
…-lockfile Update dependency puppeteer to v24.11.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonreact-library/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
.github/workflows/npm-ci.yml(1 hunks)package.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
🔇 Additional comments (1)
.github/workflows/npm-ci.yml (1)
15-15: Broader Node matrix recommended for real-world coverageRunning CI exclusively on Node 22 drops coverage for the current LTS (Node 20) and the still-widely-used maintenance LTS (Node 18). Many consumers will run those versions in production. Consider keeping at least the active LTS lines to surface incompatibilities early.
Would you like a quick patch that restores
18and20while retaining22?
| run: | | ||
| npm ci | ||
| rm package-lock.json | ||
| npm i | ||
| npm run lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lock-file removal + npm i breaks reproducible builds
Deleting package-lock.json and switching from npm ci to npm i:
- Disables deterministic dependency resolution, defeating the lock-file’s purpose.
- Slows the job (
npm ciis optimised for CI, skips audits, and respects the lock). - Obscures vulnerability scanning tools that rely on the lock-file.
Recommend reverting to npm ci (or npm ci --prefer-offline --no-audit --no-fund if speed is a concern) and keeping the lock-file intact.
- rm package-lock.json
- npm i
+ npm ci --prefer-offline --no-audit --no-fund📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| run: | | |
| npm ci | |
| rm package-lock.json | |
| npm i | |
| npm run lint | |
| run: | | |
| npm ci --prefer-offline --no-audit --no-fund | |
| npm run lint |
🤖 Prompt for AI Agents
In .github/workflows/npm-ci.yml around lines 22 to 25, the current script
deletes package-lock.json and uses npm i, which breaks reproducible builds and
slows the job. To fix this, remove the line that deletes package-lock.json and
replace npm i with npm ci (optionally with --prefer-offline --no-audit --no-fund
flags for speed). This preserves deterministic dependency resolution, speeds up
the job, and maintains compatibility with vulnerability scanning tools.
…components-vite-9.x-lockfile Update dependency @storybook/web-components-vite to v9.1.6
…prettier-10.x-lockfile Update dependency eslint-config-prettier to v10.1.8
…kfile Update dependency @types/react to v18.3.25
…components-9.x-lockfile Update dependency @storybook/web-components to v9.1.9
…n-links-9.x-lockfile Update dependency @storybook/addon-links to v9.1.9
…n-docs-9.x-lockfile Update dependency @storybook/addon-docs to v9.1.9
Update dependency jest-cli to v30
…int-eslint-plugin-8.x-lockfile Update dependency @typescript-eslint/eslint-plugin to v8.45.0
Update dependency @types/node to v24
…components-vite-9.x-lockfile Update dependency @storybook/web-components-vite to v9.1.9
….x-lockfile Update dependency iconify-icon to v3.0.1
Update dependency jest to v30
Summary by CodeRabbit