Skip to content

Conversation

@ThomasJejkal
Copy link
Contributor

@ThomasJejkal ThomasJejkal commented Feb 25, 2025

Summary by CodeRabbit

  • Chores
    • Updated core framework and development dependencies to their latest versions for improved stability.
    • Added default value documentation for several optional properties in the DataCard component.
    • Corrected minor punctuation in the README for clearer documentation.
    • Improved continuous integration workflow to streamline package installation and target Node.js version 22.

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2025

Warning

Rate limit exceeded

@ThomasJejkal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 822fec3 and 423d840.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • react-library/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • react-library/package.json (1 hunks)

Walkthrough

The pull request updates multiple dependency versions in package.json, including @stencil/core from 4.26.0 to 4.35.1, iconify-icon from ^2.1.0 to ^3.0.0, @stencil/react-output-target from ^0.8.0 to ^1.0.0, several Storybook packages from ^8.4.2 to ^9.0.4 with some package removals and additions, @types/node from ^22.9.0 to ^22.15.19, and typescript from ^5.6.3 to ^5.8.3. It also adds JSDoc default value annotations to optional properties in the DataCard interface and adds a trailing comma in the Stencil config. The GitHub Actions workflow was updated to run only on Node.js 22 and changed the install step.

Changes

File Change Summary
package.json, react-library/package.json Updated dependency versions: @stencil/core 4.26.0 → 4.35.1, iconify-icon ^2.1.0 → ^3.0.0, @stencil/react-output-target ^0.8.0 → ^1.0.0, Storybook packages ^8.4.2 → ^9.0.4 with package removals and additions, @types/node ^22.9.0 → ^22.15.19, typescript ^5.6.3 → ^5.8.3
src/components.d.ts Added JSDoc @default annotations to optional properties childrenVariant, nested, and variant in DataCard interface in both Components and LocalJSX namespaces
stencil.config.ts Added trailing comma after outDir property in reactOutputTarget configuration
readme.md Added missing period at the end of a sentence in the README documentation
.github/workflows/npm-ci.yml Updated GitHub Actions workflow to run only on Node.js 22; changed install step to remove package-lock.json and run npm i instead of npm ci

Poem

I'm a rabbit with a hop so bright,
Dependencies updated just right,
Core and icons, Storybook too,
Defaults declared, commas new,
Workflow tuned, my joy takes flight! 🐇✨

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

renovate bot and others added 21 commits February 25, 2025 21:45
…lockfile

Update dependency storybook to v8.6.0
…components-vite-8.x-lockfile

Update dependency @storybook/web-components-vite to v8.6.0
…components-8.x-lockfile

Update dependency @storybook/web-components to v8.6.1
…prettier-10.x-lockfile

Update dependency eslint-config-prettier to v10.0.2
…lockfile

Update dependency storybook to v8.6.2
…components-8.x-lockfile

Update dependency @storybook/web-components to v8.6.2
…components-vite-8.x-lockfile

Update dependency @storybook/web-components-vite to v8.6.2
…ks-8.x-lockfile

Update dependency @storybook/blocks to v8.6.2
renovate bot and others added 5 commits June 30, 2025 07:07
…output-target-1.x-lockfile

Update dependency @stencil/react-output-target to v1.1.1
…n-docs-9.x-lockfile

Update dependency @storybook/addon-docs to v9.0.14
…-lockfile

Update dependency puppeteer to v24.11.1
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31bb561 and 822fec3.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • react-library/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • .github/workflows/npm-ci.yml (1 hunks)
  • package.json (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
🔇 Additional comments (1)
.github/workflows/npm-ci.yml (1)

15-15: Broader Node matrix recommended for real-world coverage

Running CI exclusively on Node 22 drops coverage for the current LTS (Node 20) and the still-widely-used maintenance LTS (Node 18). Many consumers will run those versions in production. Consider keeping at least the active LTS lines to surface incompatibilities early.

Would you like a quick patch that restores 18 and 20 while retaining 22?

Comment on lines 22 to 25
run: |
npm ci
rm package-lock.json
npm i
npm run lint
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Lock-file removal + npm i breaks reproducible builds

Deleting package-lock.json and switching from npm ci to npm i:

  1. Disables deterministic dependency resolution, defeating the lock-file’s purpose.
  2. Slows the job (npm ci is optimised for CI, skips audits, and respects the lock).
  3. Obscures vulnerability scanning tools that rely on the lock-file.

Recommend reverting to npm ci (or npm ci --prefer-offline --no-audit --no-fund if speed is a concern) and keeping the lock-file intact.

-          rm package-lock.json
-          npm i
+          npm ci --prefer-offline --no-audit --no-fund
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: |
npm ci
rm package-lock.json
npm i
npm run lint
run: |
npm ci --prefer-offline --no-audit --no-fund
npm run lint
🤖 Prompt for AI Agents
In .github/workflows/npm-ci.yml around lines 22 to 25, the current script
deletes package-lock.json and uses npm i, which breaks reproducible builds and
slows the job. To fix this, remove the line that deletes package-lock.json and
replace npm i with npm ci (optionally with --prefer-offline --no-audit --no-fund
flags for speed). This preserves deterministic dependency resolution, speeds up
the job, and maintains compatibility with vulnerability scanning tools.

renovate bot and others added 24 commits September 15, 2025 08:48
…components-vite-9.x-lockfile

Update dependency @storybook/web-components-vite to v9.1.6
…prettier-10.x-lockfile

Update dependency eslint-config-prettier to v10.1.8
…kfile

Update dependency @types/react to v18.3.25
…components-9.x-lockfile

Update dependency @storybook/web-components to v9.1.9
…n-links-9.x-lockfile

Update dependency @storybook/addon-links to v9.1.9
…n-docs-9.x-lockfile

Update dependency @storybook/addon-docs to v9.1.9
…int-eslint-plugin-8.x-lockfile

Update dependency @typescript-eslint/eslint-plugin to v8.45.0
…components-vite-9.x-lockfile

Update dependency @storybook/web-components-vite to v9.1.9
….x-lockfile

Update dependency iconify-icon to v3.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants