Update: numpy, pandas, sdl2 to newer versions which support ndk28c (#3164)

Author: T-Dynamos

ci/makefiles/android.mk

@@ -1,12 +1,12 @@
 # Downloads and installs the Android SDK depending on supplied platform: darwin or linux
 
 # Those android NDK/SDK variables can be override when running the file
-ANDROID_NDK_VERSION ?= 25b
+ANDROID_NDK_VERSION ?= 28c
 ANDROID_NDK_VERSION_LEGACY ?= 21e
 ANDROID_SDK_TOOLS_VERSION ?= 6514223
 ANDROID_SDK_BUILD_TOOLS_VERSION ?= 29.0.3
 ANDROID_HOME ?= $(HOME)/.android
-ANDROID_API_LEVEL ?= 35
+ANDROID_API_LEVEL ?= 36
 
 # per OS dictionary-like
 UNAME_S := $(shell uname -s)

doc/source/quickstart.rst

@@ -119,7 +119,7 @@ named ``tools``, and you will need to run extra commands to install
 the SDK packages needed. 
 
 For Android NDK, note that modern releases will only work on a 64-bit
-operating system. **The minimal, and recommended, NDK version to use is r25b:**
+operating system. **The minimal, and recommended, NDK version to use is r28c:**
 
  - `Go to ndk downloads page <https://developer.android.com/ndk/downloads/>`_
  - Windows users should create a virtual machine with an GNU Linux os
@@ -154,7 +154,7 @@ variables necessary for building on android::
     # Adjust the paths!
     export ANDROIDSDK="$HOME/Documents/android-sdk-27"
     export ANDROIDNDK="$HOME/Documents/android-ndk-r23b"
-    export ANDROIDAPI="27"  # Target API version of your application
+    export ANDROIDAPI="36"  # Target API version of your application
     export NDKAPI="21"  # Minimum supported API version of your application
     export ANDROIDNDKVER="r10e"  # Version of the NDK you installed
 

doc/source/testing_pull_requests.rst

@@ -118,7 +118,7 @@ Using python-for-android commands directly from the pull request files
         --requirements=sdl2,pyjnius,kivy,python3,pycryptodome \
         --ndk-dir=/media/DEVEL/Android/android-ndk-r20 \
         --sdk-dir=/media/DEVEL/Android/android-sdk-linux \
-        --android-api=27 \
+        --android-api=36 \
         --arch=arm64-v8a \
         --permission=VIBRATE \
         --debug
@@ -175,7 +175,7 @@ Installing python-for-android using the github's branch of the pull request
     python3 setup.py apk \
         --ndk-dir=/media/DEVEL/Android/android-ndk-r20 \
         --sdk-dir=/media/DEVEL/Android/android-sdk-linux \
-        --android-api=27 \
+        --android-api=36 \
         --arch=arm64-v8a \
         --debug
 

pythonforandroid/recipe.py

@@ -155,6 +155,11 @@ class Recipe(metaclass=RecipeMeta):
         starting from NDK r18 the `gnustl_shared` lib has been deprecated.
     '''
 
+    min_ndk_api_support = 20
+    '''
+    Minimum ndk api recipe will support.
+    '''
+
     def get_stl_library(self, arch):
         return join(
             arch.ndk_lib_dir,
@@ -375,6 +380,9 @@ def get_recipe_dir(self):
     # Public Recipe API to be subclassed if needed
 
     def download_if_necessary(self):
+        if self.ctx.ndk_api < self.min_ndk_api_support:
+            error(f"In order to build '{self.name}', you must set minimum ndk api (minapi) to `{self.min_ndk_api_support}`.\n")
+            exit(1)
         info_main('Downloading {}'.format(self.name))
         user_dir = environ.get('P4A_{}_DIR'.format(self.name.lower()))
         if user_dir is not None:

pythonforandroid/recipes/numpy/__init__.py

@@ -1,17 +1,17 @@
 from pythonforandroid.recipe import Recipe, MesonRecipe
-from pythonforandroid.logger import error
 from os.path import join
 import shutil
 
 NUMPY_NDK_MESSAGE = "In order to build numpy, you must set minimum ndk api (minapi) to `24`.\n"
 
 
 class NumpyRecipe(MesonRecipe):
-    version = 'v1.26.5'
+    version = 'v2.3.0'
     url = 'git+https://github.com/numpy/numpy'
-    hostpython_prerequisites = ["Cython>=3.0.6"]  # meson does not detects venv's cython
+    hostpython_prerequisites = ["Cython>=3.0.6", "numpy"]  # meson does not detects venv's cython
     extra_build_args = ['-Csetup-args=-Dblas=none', '-Csetup-args=-Dlapack=none']
     need_stl_shared = True
+    min_ndk_api_support = 24
 
     def get_recipe_meson_options(self, arch):
         options = super().get_recipe_meson_options(arch)
@@ -36,13 +36,6 @@ def get_recipe_env(self, arch, **kwargs):
                 "python3", self.ctx).get_build_dir(arch.arch), "android-build", "python")
         return env
 
-    def download_if_necessary(self):
-        # NumPy requires complex math functions which were added in api 24
-        if self.ctx.ndk_api < 24:
-            error(NUMPY_NDK_MESSAGE)
-            exit(1)
-        super().download_if_necessary()
-
     def build_arch(self, arch):
         super().build_arch(arch)
         self.restore_hostpython_prerequisites(["cython"])

pythonforandroid/recipes/pandas/__init__.py

@@ -3,10 +3,10 @@
 
 
 class PandasRecipe(MesonRecipe):
-    version = 'v2.2.1'
-    url = 'git+https://github.com/pandas-dev/pandas'  # noqa
+    version = 'v2.3.0'
+    url = 'git+https://github.com/pandas-dev/pandas'
     depends = ['numpy', 'libbz2', 'liblzma']
-    hostpython_prerequisites = ["Cython~=3.0.5"]  # meson does not detects venv's cython
+    hostpython_prerequisites = ["Cython<4.0.0a0", "versioneer", "numpy"]  # meson does not detects venv's cython
     patches = ['fix_numpy_includes.patch']
     python_depends = ['python-dateutil', 'pytz']
     need_stl_shared = True
@@ -17,7 +17,7 @@ def get_recipe_env(self, arch, **kwargs):
         # because we need some includes generated at numpy's compile time
 
         env['NUMPY_INCLUDES'] = join(
-            self.ctx.get_python_install_dir(arch.arch), "numpy/core/include",
+            self.ctx.get_python_install_dir(arch.arch), "numpy/_core/include",
         )
         env["PYTHON_INCLUDE_DIR"] = self.ctx.python_recipe.include_root(arch)
 

pythonforandroid/recipes/python3/__init__.py

@@ -146,6 +146,14 @@ class Python3Recipe(TargetPythonRecipe):
     '''The directories from site packages dir that we don't want to be included
     in our python bundle.'''
 
+    site_packages_excluded_dir_exceptions = [
+        # 'numpy' is excluded here because importing with `import numpy as np`
+        # can fail if the `tests` directory inside the numpy package is excluded.
+        'numpy',
+    ]
+    '''Directories from `site_packages_dir_blacklist` will not be excluded
+    if the full path contains any of these exceptions.'''
+
     site_packages_filen_blacklist = [
         '*.py'
     ]
@@ -419,7 +427,8 @@ def create_python_bundle(self, dirn, arch):
         with current_directory(self.ctx.get_python_install_dir(arch.arch)):
             filens = list(walk_valid_filens(
                 '.', self.site_packages_dir_blacklist,
-                self.site_packages_filen_blacklist))
+                self.site_packages_filen_blacklist,
+                excluded_dir_exceptions=self.site_packages_excluded_dir_exceptions))
             info("Copy {} files into the site-packages".format(len(filens)))
             for filen in filens:
                 info(" - copy {}".format(filen))

pythonforandroid/recipes/sdl2/__init__.py

@@ -6,9 +6,9 @@
 
 
 class LibSDL2Recipe(BootstrapNDKRecipe):
-    version = "2.28.5"
+    version = "2.30.11"
     url = "https://github.com/libsdl-org/SDL/releases/download/release-{version}/SDL2-{version}.tar.gz"
-    md5sum = 'a344eb827a03045c9b399e99af4af13d'
+    md5sum = 'bea190b480f6df249db29eb3bacfe41e'
 
     conflicts = ['sdl3']
 

pythonforandroid/recommendations.py

@@ -13,7 +13,7 @@
 MAX_NDK_VERSION = 25
 
 # DO NOT CHANGE LINE FORMAT: buildozer parses the existence of a RECOMMENDED_NDK_VERSION
-RECOMMENDED_NDK_VERSION = "25b"
+RECOMMENDED_NDK_VERSION = "28c"
 
 NDK_DOWNLOAD_URL = "https://developer.android.com/ndk/downloads/"
 

pythonforandroid/util.py

@@ -48,7 +48,7 @@ def temp_directory():
                               temp_dir, Err_Fore.RESET)))
 
 
-def walk_valid_filens(base_dir, invalid_dir_names, invalid_file_patterns):
+def walk_valid_filens(base_dir, invalid_dir_names, invalid_file_patterns, excluded_dir_exceptions=None):
     """Recursively walks all the files and directories in ``dirn``,
     ignoring directories that match any pattern in ``invalid_dirns``
     and files that patch any pattern in ``invalid_filens``.
@@ -60,15 +60,22 @@ def walk_valid_filens(base_dir, invalid_dir_names, invalid_file_patterns):
 
     File and directory paths are evaluated as full paths relative to ``dirn``.
 
+    If ``excluded_dir_exceptions`` is given, any directory path that contains
+    any of those strings will *not* exclude subdirectories matching
+    ``invalid_dir_names``.
     """
 
+    excluded_dir_exceptions = [] if excluded_dir_exceptions is None else excluded_dir_exceptions
+
     for dirn, subdirs, filens in walk(base_dir):
+        allow_invalid_dirs = any(ex in dirn for ex in excluded_dir_exceptions)
 
         # Remove invalid subdirs so that they will not be walked
-        for i in reversed(range(len(subdirs))):
-            subdir = subdirs[i]
-            if subdir in invalid_dir_names:
-                subdirs.pop(i)
+        if not allow_invalid_dirs:
+            for i in reversed(range(len(subdirs))):
+                subdir = subdirs[i]
+                if subdir in invalid_dir_names:
+                    subdirs.pop(i)
 
         for filen in filens:
             for pattern in invalid_file_patterns: