Unable to install

[jamesdgalbraith]

I an currently trying to install Acme-Tools on Ubuntu and when running make test I am met with the error:

t/36_cmd_due.t .................. 1/6 
#   Failed test 'max'
#   at t/36_cmd_due.t line 75.
# Looks like you failed 1 test of 6.
t/36_cmd_due.t .................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/6 subtests 

The same error occurs when trying to install through cpan. I have tried install it on three different machines all running Ubuntu and it has failed on all at the same test.

[nathanhaigh]

My guess is that the input to test 36 has somehow changed.

I had a look over the test code and found it very difficult to know where the input data for the test came from. If I were the author I would try to make the tests more independent and able to run without relying on the output generated from other functions, especially those of the same package. for this specific failing test, I would probably change the test from:

ok(maxs(@d) eq '1998/07/09','max');

to something like:

cmp_ok(maxs('1998/07/09', '1998/07/10'), 'eq', '1998/07/10', 'max')

Using Test::More's cmp_ok will also output additional test info such as "expected" and "got" values when something fails. This should provide a more robust test and more useful output in the event of test failure.

[kjetillll]

I think this test bug is caused by timezone differences between me and you (sometimes we have different dates). If thats the case, I've improved t/36_cmd_due.t now and the following might work for you now:

sudo apt install git #if not done before
git clone https://github.com/kjetillll/Acme-Tools.git #the very newest not on cpan yet
cd Acme-Tools
perl Makefile.PL && make test

[kjetillll]

@nathanhaigh Those are good tips. Getting better output for failed tests. I've swapped ok() with is() a few places now and would have found the (likely) problem much faster if that was used from the get go.