Skip to content

Commit b909e8e

Browse files
committed
chore: rabbit-review-addressed
1 parent 35f733c commit b909e8e

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

src/lib/dropdown/select/simple-button.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const SimpleButton: React.FC<ISimpleButton> = ({
4343
</SelectValue>
4444
</small>
4545
) : (
46-
<h1
46+
<span
4747
className={cn(
4848
"hover-short-transition",
4949
"text-klerosUIComponentsPrimaryBlue text-2xl font-semibold",
@@ -56,7 +56,7 @@ const SimpleButton: React.FC<ISimpleButton> = ({
5656
isPlaceholder ? placeholder : selectedText
5757
}
5858
</SelectValue>
59-
</h1>
59+
</span>
6060
)}
6161
<Arrow
6262
className={cn(

src/lib/form/datepicker/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ function DatePicker({
5959

6060
<Popover
6161
className={clsx(
62-
"bg-klerosUIComponentsWhiteBackground shadow-default rounded-base",
63-
"border-klerosUIComponentsStroke ease-ease border transition",
62+
"bg-klerosUIComponentsWhiteBackground shadow-default rounded-base overflow-y-scroll",
63+
"border-klerosUIComponentsStroke ease-ease scrollbar border transition",
6464
time ? "w-82.5 lg:w-112.5" : "w-82.5",
6565
)}
6666
>

src/lib/form/file-uploader.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ import clsx from "clsx";
1717

1818
interface FileUploaderProps {
1919
/** Callback function that passes the selected file as argument. */
20-
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
21-
callback: Function;
20+
callback: (file: File) => void;
2221
msg?: string;
2322
variant?: "success" | "warning" | "error" | "info";
2423
acceptedFileTypes?: FileTriggerProps["acceptedFileTypes"];

src/lib/form/text-area.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import InfoIcon from "../../assets/svgs/status-icons/info.svg";
77
import {
88
type InputProps,
99
Label,
10-
TextArea as AriaTextAria,
10+
TextArea as AriaTextArea,
1111
TextField,
1212
type TextFieldProps,
1313
type TextAreaProps as AriaTextAreaProps,
@@ -51,7 +51,7 @@ function TextArea({
5151
{label}
5252
</Label>
5353
)}
54-
<AriaTextAria
54+
<AriaTextArea
5555
placeholder={placeholder}
5656
{...props.inputProps}
5757
className={cn(

src/lib/form/text-field.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ function TextField({
8383
"border-l-klerosUIComponentsStroke rounded-r-base border-l",
8484
"flex items-center justify-center",
8585
)}
86+
aria-hidden="true"
8687
>
8788
<Icon className="size-6" />
8889
</div>

src/lib/progress/timeline/bullet.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ const Bullet: React.FC<BulletProps> = (props) => {
4141
aria-label={`Timeline item: ${title}`}
4242
role="listitem"
4343
aria-current={state === "active" ? "step" : undefined}
44-
aria-busy={state === "loading" ? true : false}
45-
aria-disabled={state === "disabled" ? true : false}
44+
aria-busy={state === "loading"}
45+
aria-disabled={state === "disabled"}
4646
>
4747
<Spine {...{ variant, line, Icon, titleRef }} />
4848
<div
@@ -71,7 +71,7 @@ const Bullet: React.FC<BulletProps> = (props) => {
7171
>
7272
{title}
7373
</h2>
74-
{typeof party === `string` ? (
74+
{typeof party === "string" ? (
7575
<p
7676
className={clsx(
7777
"text-sm font-normal break-words",

0 commit comments

Comments
 (0)