Style of arrays, hashes and sets

[johnkoht]

I've noticed some ugly spacing with arrays, hashes and sets, like the following:

def technology_process_params
        params.require(:technology_process).permit(
                                              :type,
                                              :technology_id,
                                              :cohort_id,
                                              :user_id,
                                              :parent_id,
                                              :name,
                                              :description,
                                              citations_attributes: [:url]
                                            )
      end

I suggest we have the opening and closing character at the same level indentation, and all items in the set be indented only once, for example:

def technology_process_params
  params.require(:technology_process).permit(
    :type,
    :technology_id,
    :cohort_id,
    :user_id,
    :parent_id,
    :name,
    :description,
    citations_attributes: [:url]
  )
end

This should go for any array or hash that you are creating that is too long, some more examples:

# Hash examles
hash = {
  key_1: value,
  key_2: value2,
  ...
}

# Array example
array = [
  "Something",
  "Another super cool thing",
  "And one more for the win"
]

Thoughts on this? Agree/disagree?

[j-mcnally]

👍

[andimal]

Yeah, I'm definitely guilty of that. Normalizing to a tab is much better.

[lrdiv]

Yeah, I believe I originally proposed this, I still think it's better because if something gets added to the original method chain then we end up with x changed lines in our history instead of just the line that was modified due to adjusting indentation.

So 👍

[tjb]

👍

[johnkoht]

Should we just say that if your array or hash is more than one item it should be split into multiple lines:

# single line hash
hash = { key: value }

# single line array
array = [ item ]

And if it's more than one item then place each item on it's own line:

# multi-item hash
hash = {
  key:   value,
  key_2: value
}

# multi-item array
array = [
  item1,
  item2
]

[tjb]

I agree with anything >= 2 elements in a hash or array. 👍 for readability.