From 3197ea4d0d7c9c5eca10bab4aa339a4ce99e0c61 Mon Sep 17 00:00:00 2001 From: AYehia0 Date: Sat, 18 Nov 2023 16:23:29 +0200 Subject: [PATCH 1/2] Removed wrong warning when exit is used in repl mode --- app/commands.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/commands.go b/app/commands.go index 732ad766..49d58033 100644 --- a/app/commands.go +++ b/app/commands.go @@ -104,7 +104,7 @@ func newOldCommand(flags *flags, ui cui.UI) *command { } defer func() { - if err == nil { + if err != nil { ui.Warn("evans: deprecated usage, please use sub-commands. see `evans -h` for more details.") } }() From be1fae839f973cd30d573da190cf354738efaa5f Mon Sep 17 00:00:00 2001 From: AYehia0 Date: Sat, 18 Nov 2023 17:10:04 +0200 Subject: [PATCH 2/2] Panic removed : when failed to resolve service is thrown --- repl/completer.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/repl/completer.go b/repl/completer.go index 9a541091..8a453d9b 100644 --- a/repl/completer.go +++ b/repl/completer.go @@ -1,7 +1,6 @@ package repl import ( - "fmt" "regexp" "strings" @@ -144,7 +143,7 @@ func newCompleter(cmds map[string]commander) *completer { for _, svc := range svcs { rpcs, err := usecase.ListRPCs(svc) if err != nil { - panic(fmt.Sprintf("ListRPCs must not return an error, but got '%s'", err)) + return nil } for _, rpc := range rpcs { if _, found := encountered[rpc.RequestType.Name]; !found {