Skip to content

Commit 283cd92

Browse files
committed
cargo-release process seems solid enough to automate tag creation/pushing
we used to do this manually because failures were common from cargo-release while waiting for the crate to be present on crates.io. this no longer seems to be the case (particularly with the 20s wait time enforced), so telling it to publish,tag,push all by itself to lessen number of manual steps. Signed-off-by: clux <sszynrae@gmail.com>
1 parent c1e8e64 commit 283cd92

File tree

2 files changed

+8
-22
lines changed

2 files changed

+8
-22
lines changed

release.toml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@
44
#
55
# 0. (optional) cargo release minor ; verify readme + changelog bumped; then git reset --hard
66
# 1. PUBLISH_GRACE_SLEEP=20 cargo release minor --execute
7-
# 1X. - on failure: follow plan manually, cd into next dirs and publish insequence with cargo publish --features=k8s-openapi/latest
8-
# 2. check consolidated commit
9-
# 2X. - on failure: git commit --amend and insert version
10-
# 3. ./scripts/release-post.sh
7+
# In the event of failures:
8+
# - on partial cargo publish failures with unexpected build errors; yank partials and fix issues in a PR before retrying
9+
# - on cargo-release issues waiting for crates.io: resume publish in given order manually, cd into next dirs and publish in sequence with cargo publish --features=k8s-openapi/latest
10+
# - after publish; check consolidated commit, amend if needed, then create a manual signed tag without v prefix
1111

1212
# Reference
13-
# https://github.com/sunng87/cargo-release/blob/master/docs/reference.md
13+
# https://github.com/crate-ci/cargo-release/blob/master/docs/reference.md
1414

1515
consolidate-commits = true
1616
shared-version = true
1717
pre-release-hook = ["../scripts/release-pre.sh"]
1818
pre-release-commit-message = "release {{version}}"
19-
# leave tagging + pushing to postrelease script (due to potential failures in 1 and 2)
20-
push = false
21-
tag = false
19+
push = true
20+
tag = true
21+
tag-name = "{{version}}"
2222
# A Kubernetes version is normally supplied by the application consuming the library in the end.
2323
# Since we don't have that when verifying, supply one ourselves.
2424
enable-features = ["k8s-openapi/latest"]

scripts/release-post.sh

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)